From: Richard Henderson <richard.henderson@linaro.org>
To: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
Yuquan Wang <wangyuquan1236@phytium.com.cn>,
rad@semihalf.com, peter.maydell@linaro.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org
Cc: quic_llindhol@quicinc.com, chenbaozi@phytium.com.cn
Subject: Re: [PATCH 1/1] hw/arm/sbsa-ref: set 'slots' property of xhci
Date: Mon, 10 Jul 2023 09:14:43 +0100 [thread overview]
Message-ID: <43d15316-fb7f-71b1-2f6d-a061c5a52b34@linaro.org> (raw)
In-Reply-To: <e3050d63-844e-31f7-511d-48d31279be44@linaro.org>
On 7/10/23 08:33, Marcin Juszkiewicz wrote:
> W dniu 10.07.2023 o 09:28, Richard Henderson pisze:
>>
>> hw/usb/hcd-xhci-nec.c: DEFINE_PROP_UINT32("slots", XHCINecState, slots, XHCI_MAXSLOTS),
>> hw/usb/hcd-xhci-sysbus.c: DEFINE_PROP_UINT32("slots", XHCISysbusState, xhci.numslots,
>> XHCI_MAXSLOTS),
>>
>> The default is XCHI_MAXSLOTS, not 1. So I can't see why you'd need this.
>
> There are two systems using XHCI: i386/microvm and arm/sbsa. First
> one sets amount of slots already.
>
> Without this patch Linux complains that there is only one port and
> refuses to connect second usb device:
>
> xhci-hcd PNP0D10:00: Error while assigning device slot ID: No Slots Available Error
> xhci-hcd PNP0D10:00: Max number of devices this xHCI host supports is 1.
> usb usb1-port2: couldn't allocate usb_device
>
> So it looks like default being XHCI_MAXSLOTS is not applied somewhere.
It looks like the problem is that we're performing init and realize in one step. The
defaults would be applied later, along with other properties from the command-line.
As this is the last full day before softfreeze, and we have many other instances of the
same pattern, I'll give this an
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-07-10 8:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 6:37 [PATCH 0/1] hw/arm/sbsa-ref: set 'slots' property of xhci Yuquan Wang
2023-07-10 6:37 ` [PATCH 1/1] " Yuquan Wang
2023-07-10 7:28 ` Richard Henderson
2023-07-10 7:33 ` Marcin Juszkiewicz
2023-07-10 8:14 ` Richard Henderson [this message]
2023-07-10 10:17 ` Philippe Mathieu-Daudé
2023-07-10 7:34 ` Marcin Juszkiewicz
2023-07-13 11:39 ` [PATCH 0/1] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43d15316-fb7f-71b1-2f6d-a061c5a52b34@linaro.org \
--to=richard.henderson@linaro.org \
--cc=chenbaozi@phytium.com.cn \
--cc=marcin.juszkiewicz@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=wangyuquan1236@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).