From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 064DFC433ED for ; Sat, 24 Apr 2021 17:17:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 645CC611CA for ; Sat, 24 Apr 2021 17:17:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 645CC611CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laLty-0007MC-7b for qemu-devel@archiver.kernel.org; Sat, 24 Apr 2021 13:17:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laLrH-0006lA-Sj for qemu-devel@nongnu.org; Sat, 24 Apr 2021 13:14:19 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]:35556) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1laLrE-0006F7-Dr for qemu-devel@nongnu.org; Sat, 24 Apr 2021 13:14:19 -0400 Received: by mail-pl1-x62d.google.com with SMTP id e9so9774115plj.2 for ; Sat, 24 Apr 2021 10:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=k+yquW6Jwfr4iNaYcZTtMgJSwtJ91lwBzswa/nAFTRc=; b=dxvnPy3RWxY4pq2Z/3HHACmzvfrY0NjChJV92QJ3UE4egc4desjW86oxZACEuhumgQ LTDSOXN+P8C2ZlspWbawivnGvLLqZkb8d1ks6EQWtfCghSD9f/3nM4P0FOxg815T6bmS mqRe05FoMR5k/3WG5dffhijlbtZFktGY/92P0IqP676IJvhka/rhcwoTeouSthwRts54 O1umo35MXIkqES83zcXzWvLhMgwjXCy/JETdMLiC+wc7alXXR5btx4zfeI3VKuDnNCVN XJqWFyNENia+v2dH3BUJ+hpeu8tmS3Dc7V0TBrbWcB735spndZpCXN3TcinvURufplsD 0rPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k+yquW6Jwfr4iNaYcZTtMgJSwtJ91lwBzswa/nAFTRc=; b=FKa0hBmRmfcygfpSwBbYcrEpUzx9bbS7GRg3MA02WG0WVPKv8n2FBQ1bukaX98S6hp HqKpLLBR5Oo/+GY+M6jvkiszyjD1boGm/c/D+txLJTZ4vkwtAan0Rvzc7C5toHqXe16F OptT+irXtBrQeOzNH/2nt+jUGPeTbiavrhYCcghvh3/qmT/RFRIWopV0jEvi/w5wKNXf x/QXP14ebrxQirOiHVGtBtwULfRxWbu8AAcUMnDZm1uB6rYhYBhFAEvK2He2cmXhtoY4 zx+nB9iBsZcwzbiu598W91QSLdnQ5Lo3rgKBF/7LRaU6iJDVhIhOwIDlOHYhpXe9RFX5 phSA== X-Gm-Message-State: AOAM533gTbfgGC+I5udO/LUPNkvXVMT+fy9YwX2A6DcVSz499qW9gl7s cOT/iAfY8NltH+6aJdoeAwKbKA== X-Google-Smtp-Source: ABdhPJwt/7Ek1yO+peLSFmWhVMcd4NwppFkDruRenprbxV5vU0zo+7qB8v3v0uXtiVBpDHGSgC/qAg== X-Received: by 2002:a17:90b:344d:: with SMTP id lj13mr11925442pjb.44.1619284454798; Sat, 24 Apr 2021 10:14:14 -0700 (PDT) Received: from [192.168.1.11] ([71.212.144.24]) by smtp.gmail.com with ESMTPSA id g24sm7911741pgn.18.2021.04.24.10.14.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Apr 2021 10:14:14 -0700 (PDT) Subject: Re: [PATCH v3 10/10] target/riscv: Fix the RV64H decode comment To: Alistair Francis , qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <024ce841221c1d15c74b253512428c4baca7e4ba.1619234854.git.alistair.francis@wdc.com> From: Richard Henderson Message-ID: <43dfcf5d-26b0-759d-296b-416d3566b2ea@linaro.org> Date: Sat, 24 Apr 2021 10:14:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <024ce841221c1d15c74b253512428c4baca7e4ba.1619234854.git.alistair.francis@wdc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, bmeng.cn@gmail.com, palmer@dabbelt.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/23/21 8:34 PM, Alistair Francis wrote: > BugLink: https://gitlab.com/qemu-project/qemu/-/issues/6 The issue got renumbered to 47, fwiw. Reviewed-by: Richard Henderson r~ > Signed-off-by: Alistair Francis > --- > target/riscv/insn32.decode | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode > index fecf0f15d5..8901ba1e1b 100644 > --- a/target/riscv/insn32.decode > +++ b/target/riscv/insn32.decode > @@ -288,7 +288,7 @@ hsv_w 0110101 ..... ..... 100 00000 1110011 @r2_s > hfence_gvma 0110001 ..... ..... 000 00000 1110011 @hfence_gvma > hfence_vvma 0010001 ..... ..... 000 00000 1110011 @hfence_vvma > > -# *** RV32H Base Instruction Set *** > +# *** RV64H Base Instruction Set *** > hlv_wu 0110100 00001 ..... 100 ..... 1110011 @r2 > hlv_d 0110110 00000 ..... 100 ..... 1110011 @r2 > hsv_d 0110111 ..... ..... 100 00000 1110011 @r2_s >