From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Anton Johansson <anjo@rev.ng>,
Pierrick Bouvier <pierrick.bouvier@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-riscv <qemu-riscv@nongnu.org>
Subject: Re: [PATCH-for-10.1 1/4] target/riscv: Restrict RV128 MTTCG check on system emulation
Date: Wed, 2 Apr 2025 16:25:35 +0200 [thread overview]
Message-ID: <43e170ad-d4e3-489d-a049-22361cd34f13@linaro.org> (raw)
In-Reply-To: <2650b68f-e705-4994-9791-0bf8b2e01d74@linaro.org>
On 23/3/25 19:08, Richard Henderson wrote:
> On 3/21/25 08:59, Philippe Mathieu-Daudé wrote:
>> Multi-threaded TCG only concerns system emulation.
>
> That's not really true. User emulation simply has no option to
> run in a single-threaded context.
>
> I really don't think we should allow RV128 in user-mode at all.
> Certainly not until there's a kernel abi for it.
It seems to be safe since commit 905b9fcde1f ("target/riscv: Replace
is_32bit with get_xl/get_xlen"):
#ifdef TARGET_RISCV32
#define get_xl(ctx) MXL_RV32
#elif defined(CONFIG_USER_ONLY)
#define get_xl(ctx) MXL_RV64
#else
#define get_xl(ctx) ((ctx)->xl)
#endif
Should we undefine MXL_RV128 on user-mode?
next prev parent reply other threads:[~2025-04-02 14:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 15:59 [PATCH-for-10.1 0/4] tcg: Convert TARGET_SUPPORTS_MTTCG to TCGCPUOps::mttcg_supported field Philippe Mathieu-Daudé
2025-03-21 15:59 ` [PATCH-for-10.1 1/4] target/riscv: Restrict RV128 MTTCG check on system emulation Philippe Mathieu-Daudé
2025-03-21 17:32 ` Pierrick Bouvier
2025-03-23 18:08 ` Richard Henderson
2025-04-02 14:25 ` Philippe Mathieu-Daudé [this message]
2025-04-02 14:40 ` Philippe Mathieu-Daudé
2025-04-04 3:22 ` Alistair Francis
2025-03-21 15:59 ` [PATCH-for-10.1 2/4] tcg: Move qemu_tcg_mttcg_enabled() to 'system/tcg.h' Philippe Mathieu-Daudé
2025-03-21 17:33 ` Pierrick Bouvier
2025-03-23 18:36 ` Richard Henderson
2025-03-21 15:59 ` [PATCH-for-10.1 3/4] tcg: Convert TCGState::mttcg_enabled to TriState Philippe Mathieu-Daudé
2025-03-21 17:01 ` Anton Johansson via
2025-03-21 17:45 ` Philippe Mathieu-Daudé
2025-03-21 17:36 ` Pierrick Bouvier
2025-03-21 18:26 ` Philippe Mathieu-Daudé
2025-03-21 18:33 ` Pierrick Bouvier
2025-03-23 18:43 ` Richard Henderson
2025-04-02 21:12 ` Philippe Mathieu-Daudé
2025-03-21 15:59 ` [PATCH-for-10.1 4/4] tcg: Convert TARGET_SUPPORTS_MTTCG to TCGCPUOps::mttcg_supported field Philippe Mathieu-Daudé
2025-03-21 16:41 ` Anton Johansson via
2025-03-21 17:43 ` Pierrick Bouvier
2025-03-23 19:07 ` Richard Henderson
2025-03-23 21:24 ` Philippe Mathieu-Daudé
2025-03-23 22:13 ` BALATON Zoltan
2025-03-23 22:17 ` Richard Henderson
2025-03-23 22:49 ` BALATON Zoltan
2025-03-24 16:39 ` Philippe Mathieu-Daudé
2025-03-23 23:15 ` Philippe Mathieu-Daudé
2025-03-21 16:00 ` [PATCH-for-10.1 0/4] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e170ad-d4e3-489d-a049-22361cd34f13@linaro.org \
--to=philmd@linaro.org \
--cc=anjo@rev.ng \
--cc=pbonzini@redhat.com \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).