From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>, qemu-devel@nongnu.org
Cc: f4bug@amsat.org
Subject: Re: [PATCH 1/2] target/mips: Don't check COP1X for 64 bit FP mode
Date: Mon, 7 Nov 2022 23:47:10 +0100 [thread overview]
Message-ID: <43f4db9f-786e-c45f-f2a0-fa46fd8fa24c@linaro.org> (raw)
In-Reply-To: <20221102165719.190378-1-jiaxun.yang@flygoat.com>
On 2/11/22 17:57, Jiaxun Yang wrote:
> Some implementations (i.e. Loongson-2F) may decide to implement a 64 bit
> FPU without implmenting COP1X instructions.
>
> As the eligibility of 64 bit FP instructions is already determined by
> CP0St_FR, there is no need to check for COP1X again.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> target/mips/tcg/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c
> index 2f2d707a12..e49d2a25a8 100644
> --- a/target/mips/tcg/translate.c
> +++ b/target/mips/tcg/translate.c
> @@ -1545,7 +1545,7 @@ void check_cop1x(DisasContext *ctx)
> */
> void check_cp1_64bitmode(DisasContext *ctx)
> {
> - if (unlikely(~ctx->hflags & (MIPS_HFLAG_F64 | MIPS_HFLAG_COP1X))) {
> + if (unlikely(~ctx->hflags & MIPS_HFLAG_F64) {
> gen_reserved_instruction(ctx);
> }
> }
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2022-11-07 22:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 16:57 [PATCH 1/2] target/mips: Don't check COP1X for 64 bit FP mode Jiaxun Yang
2022-11-02 16:57 ` [PATCH 2/2] target/mips: Correct check for CABS instructions Jiaxun Yang
2022-11-07 22:35 ` Philippe Mathieu-Daudé
2022-11-08 11:37 ` Jiaxun Yang
2022-11-07 22:47 ` Philippe Mathieu-Daudé [this message]
2022-11-07 23:29 ` [PATCH 1/2] target/mips: Don't check COP1X for 64 bit FP mode Philippe Mathieu-Daudé
2022-11-08 11:38 ` Jiaxun Yang
2022-11-07 23:22 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43f4db9f-786e-c45f-f2a0-fa46fd8fa24c@linaro.org \
--to=philmd@linaro.org \
--cc=f4bug@amsat.org \
--cc=jiaxun.yang@flygoat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).