From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Fabiano Rosas <farosas@suse.de>,
Claudio Fontana <cfontana@suse.de>,
qemu-arm@nongnu.org
Subject: Re: [PATCH-for-8.0 1/2] target/arm/gdbstub: Restrict aarch64_gdb_get_pauth_reg() to CONFIG_TCG
Date: Tue, 28 Mar 2023 15:34:37 +0200 [thread overview]
Message-ID: <441e78f2-962f-6b46-4bf9-09e8ef75fbe4@linaro.org> (raw)
In-Reply-To: <f4d1705b-6163-37d0-8516-637aaf7cc796@linaro.org>
On 22/3/23 16:15, Richard Henderson wrote:
> On 3/22/23 07:29, Philippe Mathieu-Daudé wrote:
>> aarch64_gdb_get_pauth_reg() -- although disabled since commit
>> 5787d17a42 ("target/arm: Don't advertise aarch64-pauth.xml to
>> gdb") is still compiled in. It calls pauth_ptr_mask() which is
>> located in target/arm/tcg/pauth_helper.c, a TCG specific helper.
>>
>> Restrict aarch64_gdb_get_pauth_reg() to TCG to avoid a linking
>> error when TCG is not enabled:
>>
>> Undefined symbols for architecture arm64:
>> "_pauth_ptr_mask", referenced from:
>> _aarch64_gdb_get_pauth_reg in target_arm_gdbstub64.c.o
>> ld: symbol(s) not found for architecture arm64
>> clang: error: linker command failed with exit code 1 (use -v to see
>> invocation)
>
> I guess we should move this function somewhere else, because KVM can
> certainly use pauth, and we do want to be able to produce nice
> backtraces with gdb.
I ended inlining it (along with pauth_ptr_mask_internal,
renamed as pauth_param_mask):
https://lore.kernel.org/qemu-devel/20230328133054.6553-3-philmd@linaro.org/
next prev parent reply other threads:[~2023-03-28 13:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 14:29 [PATCH-for-8.0 0/2] target/arm/gdbstub: Fix builds when TCG is disabled Philippe Mathieu-Daudé
2023-03-22 14:29 ` [PATCH-for-8.0 1/2] target/arm/gdbstub: Restrict aarch64_gdb_get_pauth_reg() to CONFIG_TCG Philippe Mathieu-Daudé
2023-03-22 15:15 ` Richard Henderson
2023-03-28 13:34 ` Philippe Mathieu-Daudé [this message]
2023-03-22 14:29 ` [PATCH-for-8.0 2/2] target/arm/gdbstub: Only advertise M-profile features if TCG available Philippe Mathieu-Daudé
2023-03-22 15:13 ` Richard Henderson
2023-03-22 16:21 ` Alex Bennée
2023-03-22 14:32 ` [PATCH-for-8.0 0/2] target/arm/gdbstub: Fix builds when TCG is disabled Philippe Mathieu-Daudé
2023-03-22 17:45 ` Fabiano Rosas
2023-03-28 9:54 ` Peter Maydell
2023-03-28 13:20 ` Philippe Mathieu-Daudé
2023-03-28 13:33 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441e78f2-962f-6b46-4bf9-09e8ef75fbe4@linaro.org \
--to=philmd@linaro.org \
--cc=cfontana@suse.de \
--cc=farosas@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).