From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FSzVc-0006fv-Ub for qemu-devel@nongnu.org; Mon, 10 Apr 2006 12:45:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FSzVa-0006ff-Ea for qemu-devel@nongnu.org; Mon, 10 Apr 2006 12:44:59 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FSzVa-0006fa-9J for qemu-devel@nongnu.org; Mon, 10 Apr 2006 12:44:58 -0400 Received: from [216.148.227.153] (helo=rwcrmhc13.comcast.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FSzaG-0001cP-7s for qemu-devel@nongnu.org; Mon, 10 Apr 2006 12:49:48 -0400 Message-ID: <443A8B88.5090804@win4lin.com> Date: Mon, 10 Apr 2006 12:44:56 -0400 From: "Leonardo E. Reiter" MIME-Version: 1.0 Subject: Re: [Qemu-devel] Updated BGR vs. RGB vga patch... References: <443A86FC.9010302@win4lin.com> <200604101735.39032.paul@codesourcery.com> In-Reply-To: <200604101735.39032.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Actually it should probably be made conditionally compiled for now, until the VGA architecture changes to something more efficient. Would you agree with that? That way, people who know they will need the hack can enable it at configure/compile time, and the rest will not be affected. How does that sound? I'd be happy to post an updated patch that does that. - Leo Paul Brook wrote: > On Monday 10 April 2006 17:25, Leonardo E. Reiter wrote: > >>Hello, >> >>attached is an updated version (against today's CVS) of a patch to >>enable B/G/R color encoding rather than R/G/B with the command-line >>option -bgr. I found the original here (post by Martin Bochnig): > > > Shouldn't we be able to figure this out by asking SDL and/or the X server? > Also, adding an if to the low-level conversion routines seems a bad idea for > performance. > > Paul -- Leonardo E. Reiter Vice President of Product Development, CTO Win4Lin, Inc. Virtual Computing from Desktop to Data Center Main: +1 512 339 7979 Fax: +1 512 532 6501 http://www.win4lin.com