From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FT1nA-00074C-GP for qemu-devel@nongnu.org; Mon, 10 Apr 2006 15:11:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FT1n9-000740-2p for qemu-devel@nongnu.org; Mon, 10 Apr 2006 15:11:16 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FT1n8-00073x-VC for qemu-devel@nongnu.org; Mon, 10 Apr 2006 15:11:14 -0400 Received: from [216.148.227.154] (helo=rwcrmhc14.comcast.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FT1rq-0007bE-Fz for qemu-devel@nongnu.org; Mon, 10 Apr 2006 15:16:06 -0400 Message-ID: <443AADD0.9000106@win4lin.com> Date: Mon, 10 Apr 2006 15:11:12 -0400 From: "Leonardo E. Reiter" MIME-Version: 1.0 Subject: Re: [Qemu-devel] Updated BGR vs. RGB vga patch... References: <443A86FC.9010302@win4lin.com> <200604101749.00725.paul@codesourcery.com> <443A8D0C.4030807@win4lin.com> <200604101759.34399.paul@codesourcery.com> <443AA2DE.3060908@win4lin.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Probably... I just don't know anything about SDL and I needed this patch to work right away with at least the command-line option. It's definitely deducible from X11, and that's very easy. - Leo Reiter malc wrote: > On Mon, 10 Apr 2006, Leonardo E. Reiter wrote: > >> Anyway, I didn't spend time figuring out how to query SDL for the >> ordering. You still have to manually pass in -bgr. The good news is >> that all the computation is now done at compile-time, with only very >> few tests done at run-time. I agree with your assessment of >> compile-time versus run-time options... I was merely suggesting a >> compromise to fend off the minor performance hit of using the old >> patch. But the method you suggested is much better and that's how >> it's implemented now. > > > I maybe going out on a limb here, but isn't rgb/bgr trivially deducible > from: sdl.c:screen->format->[RGBA]shift. > -- Leonardo E. Reiter Vice President of Product Development, CTO Win4Lin, Inc. Virtual Computing from Desktop to Data Center Main: +1 512 339 7979 Fax: +1 512 532 6501 http://www.win4lin.com