From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1FYAwQ-0005dY-PK
	for qemu-devel@nongnu.org; Mon, 24 Apr 2006 19:58:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1FYAwO-0005d1-SZ
	for qemu-devel@nongnu.org; Mon, 24 Apr 2006 19:58:06 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1FYAwO-0005cy-Pg
	for qemu-devel@nongnu.org; Mon, 24 Apr 2006 19:58:04 -0400
Received: from [213.165.64.20] (helo=mail.gmx.net)
	by monty-python.gnu.org with smtp (Exim 4.52) id 1FYAyj-0002J0-Jo
	for qemu-devel@nongnu.org; Mon, 24 Apr 2006 20:00:29 -0400
Message-ID: <444D660D.1060604@gmx.de>
Date: Tue, 25 Apr 2006 01:58:05 +0200
From: nix.wie.weg@gmx.de
MIME-Version: 1.0
Subject: Re: [Qemu-devel] qemu/hw usb-uhci.c
References: <E1FY8le-0003E5-Jg@savannah.gnu.org>
In-Reply-To: <E1FY8le-0003E5-Jg@savannah.gnu.org>
Content-Type: multipart/mixed; boundary="------------040501030109000404090405"
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is a multi-part message in MIME format.
--------------040501030109000404090405
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hello Fabrice,

This patch introduces an already fixed bug with linux guest os. The
message is: "controller still running". The attached patch fixes this
problem.
Believe me it would save both of us a lot of time, if you would simply
add the large usb patch.

With kind regards,
Tino H. Seifert

Fabrice Bellard wrote:
> CVSROOT:	/sources/qemu
> Module name:	qemu
> Branch: 	
> Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/04/24 21:38:50
>
> Modified files:
> 	hw             : usb-uhci.c 
>
> Log message:
> 	HCHALTED status bit handling (Lonnie Mendez)
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/hw/usb-uhci.c.diff?tr1=1.6&tr2=1.7&r1=text&r2=text
>
>
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
>
>
>   

--------------040501030109000404090405
Content-Type: text/x-patch;
 name="usb.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="usb.patch"

Index: hw/usb-uhci.c
===================================================================
RCS file: /sources/qemu/qemu/hw/usb-uhci.c,v
retrieving revision 1.7
diff -u -r1.7 usb-uhci.c
--- hw/usb-uhci.c	24 Apr 2006 21:38:50 -0000	1.7
+++ hw/usb-uhci.c	24 Apr 2006 23:00:49 -0000
@@ -175,7 +175,7 @@
             /* start frame processing */
             qemu_mod_timer(s->frame_timer, qemu_get_clock(vm_clock));
             s->status &= ~UHCI_STS_HCHALTED;
-        } else if (!(val & UHCI_CMD_RS) && !(s->cmd & UHCI_CMD_RS)) {
+        } else if (!(val & UHCI_CMD_RS)) {
             s->status |= UHCI_STS_HCHALTED;
         }
         if (val & UHCI_CMD_GRESET) {

--------------040501030109000404090405--