From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FYBYO-0002AN-KI for qemu-devel@nongnu.org; Mon, 24 Apr 2006 20:37:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FYBYM-00028p-WF for qemu-devel@nongnu.org; Mon, 24 Apr 2006 20:37:20 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FYBYM-00028m-S4 for qemu-devel@nongnu.org; Mon, 24 Apr 2006 20:37:18 -0400 Received: from [24.93.47.40] (helo=ms-smtp-01.texas.rr.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FYBai-0005DB-3S for qemu-devel@nongnu.org; Mon, 24 Apr 2006 20:39:44 -0400 Received: from [192.168.0.11] (cpe-67-9-160-120.austin.res.rr.com [67.9.160.120]) by ms-smtp-01.texas.rr.com (8.13.4/8.13.4) with ESMTP id k3P0bFFw025872 for ; Mon, 24 Apr 2006 19:37:16 -0500 (CDT) Message-ID: <444D6F38.3030301@austin.rr.com> Date: Mon, 24 Apr 2006 19:37:12 -0500 From: Lonnie Mendez MIME-Version: 1.0 Subject: Re: [Qemu-devel] qemu/hw usb-uhci.c References: <444D660D.1060604@gmx.de> In-Reply-To: <444D660D.1060604@gmx.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org nix.wie.weg@gmx.de wrote: >Hello Fabrice, > >This patch introduces an already fixed bug with linux guest os. The >message is: "controller still running". The attached patch fixes this >problem. > > To expand on this, I saw windows checking the status register several times to look for hchalt once R/S bit was written 0. However, Linux guest hcd only checks the status register once before giving up. So the much simpler patch here works in both cases. However, it also means we can't properly indicate when the frame has really stopped and the host controller halted. This isn't something that shows up with the code in CVS because the hub is always attached and thus the linux hcd doesn't try to suspend the bus (Windows XP will do this and there is a patch I'll try to submit later on this week - very busy).