From: Fabrice Bellard <fabrice@bellard.org>
To: nix.wie.weg@gmx.de
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu/hw usb-uhci.c
Date: Tue, 25 Apr 2006 23:03:32 +0200 [thread overview]
Message-ID: <444E8EA4.4050207@bellard.org> (raw)
In-Reply-To: <444D660D.1060604@gmx.de>
OK for the UHCI fix.
I need more time to accept your big patch. I think it would have been
better to separate the bug fixes, the new USB host drivers and the API
changes. I would have included the first two without problem, but I need
to better understand your API changes before commiting them.
Regards,
Fabrice.
nix.wie.weg@gmx.de wrote:
> Hello Fabrice,
>
> This patch introduces an already fixed bug with linux guest os. The
> message is: "controller still running". The attached patch fixes this
> problem.
> Believe me it would save both of us a lot of time, if you would simply
> add the large usb patch.
>
> With kind regards,
> Tino H. Seifert
>
> Fabrice Bellard wrote:
>
>>CVSROOT: /sources/qemu
>>Module name: qemu
>>Branch:
>>Changes by: Fabrice Bellard <bellard@savannah.gnu.org> 06/04/24 21:38:50
>>
>>Modified files:
>> hw : usb-uhci.c
>>
>>Log message:
>> HCHALTED status bit handling (Lonnie Mendez)
>>
>>CVSWeb URLs:
>>http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/hw/usb-uhci.c.diff?tr1=1.6&tr2=1.7&r1=text&r2=text
>>
>>
>>_______________________________________________
>>Qemu-devel mailing list
>>Qemu-devel@nongnu.org
>>http://lists.nongnu.org/mailman/listinfo/qemu-devel
>>
>>
>>
>>
>>
>>------------------------------------------------------------------------
>>
>>Index: hw/usb-uhci.c
>>===================================================================
>>RCS file: /sources/qemu/qemu/hw/usb-uhci.c,v
>>retrieving revision 1.7
>>diff -u -r1.7 usb-uhci.c
>>--- hw/usb-uhci.c 24 Apr 2006 21:38:50 -0000 1.7
>>+++ hw/usb-uhci.c 24 Apr 2006 23:00:49 -0000
>>@@ -175,7 +175,7 @@
>> /* start frame processing */
>> qemu_mod_timer(s->frame_timer, qemu_get_clock(vm_clock));
>> s->status &= ~UHCI_STS_HCHALTED;
>>- } else if (!(val & UHCI_CMD_RS) && !(s->cmd & UHCI_CMD_RS)) {
>>+ } else if (!(val & UHCI_CMD_RS)) {
>> s->status |= UHCI_STS_HCHALTED;
>> }
>> if (val & UHCI_CMD_GRESET) {
>>
>>
>>------------------------------------------------------------------------
>>
>>_______________________________________________
>>Qemu-devel mailing list
>>Qemu-devel@nongnu.org
>>http://lists.nongnu.org/mailman/listinfo/qemu-devel
next prev parent reply other threads:[~2006-04-25 21:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 21:38 [Qemu-devel] qemu/hw usb-uhci.c Fabrice Bellard
2006-04-24 23:58 ` nix.wie.weg
2006-04-25 0:37 ` Lonnie Mendez
2006-04-25 21:03 ` Fabrice Bellard [this message]
2006-04-25 21:25 ` Johannes Schindelin
-- strict thread matches above, loose matches on Subject: below --
2007-11-11 19:46 Fabrice Bellard
2007-02-22 20:21 Thiemo Seufer
2007-01-17 23:08 Thiemo Seufer
2006-04-25 21:01 Fabrice Bellard
2006-03-11 21:46 Paul Brook
2005-11-19 17:43 Fabrice Bellard
2005-11-05 17:22 Fabrice Bellard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444E8EA4.4050207@bellard.org \
--to=fabrice@bellard.org \
--cc=nix.wie.weg@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).