From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FYUo0-0007kF-RP for qemu-devel@nongnu.org; Tue, 25 Apr 2006 17:10:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FYUnz-0007j3-W4 for qemu-devel@nongnu.org; Tue, 25 Apr 2006 17:10:44 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FYUnz-0007in-NX for qemu-devel@nongnu.org; Tue, 25 Apr 2006 17:10:43 -0400 Received: from [84.96.92.55] (helo=smtP.neuf.fr) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FYUqW-0004Z6-Sv for qemu-devel@nongnu.org; Tue, 25 Apr 2006 17:13:21 -0400 Received: from [84.102.211.96] by sp604004mt.gpm.neuf.ld (Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006)) with ESMTP id <0IYA000X1QJ7K4I0@sp604004mt.gpm.neuf.ld> for qemu-devel@nongnu.org; Tue, 25 Apr 2006 23:04:19 +0200 (CEST) Date: Tue, 25 Apr 2006 23:03:32 +0200 From: Fabrice Bellard Subject: Re: [Qemu-devel] qemu/hw usb-uhci.c In-reply-to: <444D660D.1060604@gmx.de> Message-id: <444E8EA4.4050207@bellard.org> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii; format=flowed Content-transfer-encoding: 7BIT References: <444D660D.1060604@gmx.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: nix.wie.weg@gmx.de Cc: qemu-devel@nongnu.org OK for the UHCI fix. I need more time to accept your big patch. I think it would have been better to separate the bug fixes, the new USB host drivers and the API changes. I would have included the first two without problem, but I need to better understand your API changes before commiting them. Regards, Fabrice. nix.wie.weg@gmx.de wrote: > Hello Fabrice, > > This patch introduces an already fixed bug with linux guest os. The > message is: "controller still running". The attached patch fixes this > problem. > Believe me it would save both of us a lot of time, if you would simply > add the large usb patch. > > With kind regards, > Tino H. Seifert > > Fabrice Bellard wrote: > >>CVSROOT: /sources/qemu >>Module name: qemu >>Branch: >>Changes by: Fabrice Bellard 06/04/24 21:38:50 >> >>Modified files: >> hw : usb-uhci.c >> >>Log message: >> HCHALTED status bit handling (Lonnie Mendez) >> >>CVSWeb URLs: >>http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/hw/usb-uhci.c.diff?tr1=1.6&tr2=1.7&r1=text&r2=text >> >> >>_______________________________________________ >>Qemu-devel mailing list >>Qemu-devel@nongnu.org >>http://lists.nongnu.org/mailman/listinfo/qemu-devel >> >> >> >> >> >>------------------------------------------------------------------------ >> >>Index: hw/usb-uhci.c >>=================================================================== >>RCS file: /sources/qemu/qemu/hw/usb-uhci.c,v >>retrieving revision 1.7 >>diff -u -r1.7 usb-uhci.c >>--- hw/usb-uhci.c 24 Apr 2006 21:38:50 -0000 1.7 >>+++ hw/usb-uhci.c 24 Apr 2006 23:00:49 -0000 >>@@ -175,7 +175,7 @@ >> /* start frame processing */ >> qemu_mod_timer(s->frame_timer, qemu_get_clock(vm_clock)); >> s->status &= ~UHCI_STS_HCHALTED; >>- } else if (!(val & UHCI_CMD_RS) && !(s->cmd & UHCI_CMD_RS)) { >>+ } else if (!(val & UHCI_CMD_RS)) { >> s->status |= UHCI_STS_HCHALTED; >> } >> if (val & UHCI_CMD_GRESET) { >> >> >>------------------------------------------------------------------------ >> >>_______________________________________________ >>Qemu-devel mailing list >>Qemu-devel@nongnu.org >>http://lists.nongnu.org/mailman/listinfo/qemu-devel