From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1FYsL9-0005D5-Np
	for qemu-devel@nongnu.org; Wed, 26 Apr 2006 18:18:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1FYsL9-0005Cs-Bp
	for qemu-devel@nongnu.org; Wed, 26 Apr 2006 18:18:31 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1FYsL9-0005Cp-5x
	for qemu-devel@nongnu.org; Wed, 26 Apr 2006 18:18:31 -0400
Received: from [84.96.92.55] (helo=smtP.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1FYsNv-0000da-5y
	for qemu-devel@nongnu.org; Wed, 26 Apr 2006 18:21:23 -0400
Received: from [86.73.70.201] by sp604004mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0IYC00JX6OLU0X41@sp604004mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Thu, 27 Apr 2006 00:17:54 +0200 (CEST)
Date: Thu, 27 Apr 2006 00:17:08 +0200
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] [PATCH][MIPS] FPU support for MIPS
In-reply-to: <Pine.LNX.4.64.0604261622190.30332@mag.sysgo.com>
Message-id: <444FF164.2060104@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii; format=flowed
Content-transfer-encoding: 7BIT
References: <Pine.LNX.4.64.0604261622190.30332@mag.sysgo.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

A few remarks:

1) Why do you use 3 temporaries ? Maybe two suffice in most cases.

2) do_cmp_d() should be completely decoded at translation time.

3) I suspect the macro FPR() does too many things at runtime which gives 
an important performance loss. CP0St_FR should be known at translation time.

You should use CONFIG_SOFTFLOAT to validate your code. The ARM target 
does it, so it works (see the configure script).

Fabrice.

Marius Groeger wrote:
> Hi All,
> 
> a new version of my FPU patch, now actually doing some math. Known 
> issues include, but may not be limited to:
> 
> - only support .d format, that is IEEE 64bit
> - no proper float exception handling. If someone gets CONFIG_SOFTFLOAT
>   to compile, this should be quite easy to improve. Most of
>   the infrastructure required is in place.
> 
> Feedback welcome!
> 
> Cheers,
> Marius