From: Paolo Bonzini <pbonzini@redhat.com>
To: Roman Pen <roman.penyaev@profitbricks.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] linux-aio: prevent submitting more than MAX_EVENTS
Date: Wed, 13 Jul 2016 09:43:59 +0200 [thread overview]
Message-ID: <444e730b-eee6-4b18-4b90-cb1b39e13421@redhat.com> (raw)
In-Reply-To: <1468345887-22077-1-git-send-email-roman.penyaev@profitbricks.com>
On 12/07/2016 19:51, Roman Pen wrote:
> + if (s->io_q.in_flight >= MAX_EVENTS)
> + break;
> QSIMPLEQ_FOREACH(aiocb, &s->io_q.pending, next) {
> iocbs[len++] = &aiocb->iocb;
> - if (len == MAX_QUEUED_IO) {
> + if (s->io_q.in_flight + len >= MAX_EVENTS) {
> break;
> }
More easily written like this:
QSIMPLEQ_FOREACH(aiocb, &s->io_q.pending, next) {
if (s->io_q.in_flight + len >= MAX_EVENTS) {
break;
}
iocbs[len++] = &aiocb->iocb;
}
so that the early "if" is not necessary. Also because you forgot the
braces around it. :)
Paolo
next prev parent reply other threads:[~2016-07-13 7:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 17:51 [Qemu-devel] [PATCH 1/1] linux-aio: prevent submitting more than MAX_EVENTS Roman Pen
2016-07-13 2:23 ` Fam Zheng
2016-07-13 7:57 ` [Qemu-devel] [PATCH V2 " Roman Pen
2016-07-13 10:31 ` Paolo Bonzini
2016-07-13 11:33 ` Roman Penyaev
2016-07-13 11:45 ` Kevin Wolf
2016-07-13 14:53 ` Roman Penyaev
2016-07-15 9:18 ` Roman Penyaev
2016-07-15 9:58 ` Paolo Bonzini
2016-07-15 10:17 ` Roman Penyaev
2016-07-15 10:37 ` Paolo Bonzini
2016-07-15 11:35 ` Roman Penyaev
2016-07-15 12:57 ` Paolo Bonzini
2016-07-15 15:03 ` Roman Penyaev
2016-07-13 12:22 ` Eric Blake
2016-07-13 12:57 ` Roman Penyaev
2016-07-14 12:18 ` Stefan Hajnoczi
2016-07-13 7:43 ` Paolo Bonzini [this message]
2016-07-13 7:50 ` [Qemu-devel] [PATCH " Roman Penyaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444e730b-eee6-4b18-4b90-cb1b39e13421@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=roman.penyaev@profitbricks.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).