From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40211)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bNEpz-0005F1-Pm
	for qemu-devel@nongnu.org; Wed, 13 Jul 2016 03:44:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bNEpv-0004hL-L4
	for qemu-devel@nongnu.org; Wed, 13 Jul 2016 03:44:06 -0400
Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:34336)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bNEpv-0004hH-Cv
	for qemu-devel@nongnu.org; Wed, 13 Jul 2016 03:44:03 -0400
Received: by mail-lf0-x244.google.com with SMTP id a10so3162685lfb.1
	for <qemu-devel@nongnu.org>; Wed, 13 Jul 2016 00:44:03 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1468345887-22077-1-git-send-email-roman.penyaev@profitbricks.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <444e730b-eee6-4b18-4b90-cb1b39e13421@redhat.com>
Date: Wed, 13 Jul 2016 09:43:59 +0200
MIME-Version: 1.0
In-Reply-To: <1468345887-22077-1-git-send-email-roman.penyaev@profitbricks.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1] linux-aio: prevent submitting more
 than MAX_EVENTS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Roman Pen <roman.penyaev@profitbricks.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org



On 12/07/2016 19:51, Roman Pen wrote:
> +        if (s->io_q.in_flight >= MAX_EVENTS)
> +            break;
>          QSIMPLEQ_FOREACH(aiocb, &s->io_q.pending, next) {
>              iocbs[len++] = &aiocb->iocb;
> -            if (len == MAX_QUEUED_IO) {
> +            if (s->io_q.in_flight + len >= MAX_EVENTS) {
>                  break;
>              }

More easily written like this:

        QSIMPLEQ_FOREACH(aiocb, &s->io_q.pending, next) {
            if (s->io_q.in_flight + len >= MAX_EVENTS) {
                break;
            }
            iocbs[len++] = &aiocb->iocb;
        }

so that the early "if" is not necessary.  Also because you forgot the
braces around it. :)

Paolo