qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Lonnie Mendez <lmendez19@austin.rr.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Large USB patch
Date: Sat, 29 Apr 2006 19:46:13 -0500	[thread overview]
Message-ID: <445408D5.3060101@austin.rr.com> (raw)
In-Reply-To: <4452DD84.8090707@austin.rr.com>

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

   lo.  The attached patch addresses the problem with removing the 
usbhub/tablet devices and switches the handle_packet call in the port 
reset call to handle_msg which just happens to make the hub functional.

[-- Attachment #2: lusb-upd5.diff --]
[-- Type: text/plain, Size: 1678 bytes --]

--- a/qemu/hw/usb-hub.c	2006-04-28 19:44:18.000000000 -0500
+++ b/qemu/hw/usb-hub.c	2006-04-29 18:55:46.000000000 -0500
@@ -240,6 +240,13 @@
     return 1;
 }
 
+int usb_hub_handle_close(USBDevice *dev)
+{
+    USBHubState *s = (USBHubState *)(dev->opaque);
+    qemu_free(s);
+    return 1;
+}
+
 int usb_hub_handle_control(USBDevice *dev, int request, int value,
                            int index, int length, uint8_t *data)
 {
@@ -385,8 +392,7 @@
                 break;
             case PORT_RESET:
                 if (dev) {
-                    dev->handle_packet(dev, 
-                                       USB_MSG_RESET, 0, 0, NULL, 0);
+                    dev->handle_msg(dev, USB_MSG_RESET);
                     port->wPortChange |= PORT_STAT_C_RESET;
                     /* set enable bit */
 //                    port->wPortChange |= PORT_STAT_C_ENABLE;
@@ -578,6 +584,7 @@
     dev->handle_packet=         usb_hub_handle_packet;
     dev->handle_attach=         usb_hub_attach;
     dev->handle_reset=          usb_hub_handle_reset;
+    dev->handle_close=          usb_hub_handle_close;
     dev->handle_control=        usb_hub_handle_control;
     dev->handle_data=           usb_hub_handle_data;
 
--- a/qemu/hw/usb-hid.c	2006-04-28 19:44:18.000000000 -0500
+++ b/qemu/hw/usb-hid.c	2006-04-29 18:56:15.000000000 -0500
@@ -526,6 +526,7 @@
     dev->handle_packet=     usb_generic_handle_packet;
 
     dev->handle_reset=      usb_mouse_handle_reset;
+    dev->handle_close=      usb_mouse_handle_close;
     dev->handle_control=    usb_mouse_handle_control;
     dev->handle_data=       usb_mouse_handle_data;
     s->kind=                USB_TABLET;

  reply	other threads:[~2006-04-30  0:46 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-20 19:59 [Qemu-devel] Large USB patch nix.wie.weg
2006-04-21  2:23 ` Lonnie Mendez
2006-04-21  5:59   ` nix.wie.weg
2006-04-21  7:04     ` Lonnie Mendez
2006-04-21 14:53 ` Lonnie Mendez
2006-04-21 15:00   ` Lonnie Mendez
2006-04-21 15:50   ` Lonnie Mendez
2006-04-21 16:19     ` Lonnie Mendez
2006-04-21 16:29       ` nix.wie.weg
2006-04-21 17:28         ` Lonnie Mendez
2006-04-21 18:06           ` Lonnie Mendez
2006-04-21 18:38             ` Lonnie Mendez
2006-04-21 20:50               ` Lonnie Mendez
2006-04-22  9:33                 ` nix.wie.weg
2006-04-22 14:36                   ` Lonnie Mendez
2006-04-22 15:36                     ` nix.wie.weg
2006-04-22 15:38                       ` nix.wie.weg
2006-04-22 16:00                     ` nix.wie.weg
2006-04-22 16:19                       ` Lonnie Mendez
2006-04-22 16:35                         ` nix.wie.weg
2006-04-23  3:38                           ` Lonnie Mendez
2006-04-23 21:54                             ` nix.wie.weg
2006-04-29  1:03                             ` Lonnie Mendez
2006-04-29  3:29                               ` Lonnie Mendez
2006-04-30  0:46                                 ` Lonnie Mendez [this message]
2006-04-30 20:56                                   ` Lonnie Mendez
2006-04-21 16:26     ` nix.wie.weg
2006-04-22 14:15 ` nix.wie.weg
2006-04-23 15:02 ` Fabrice Bellard
2006-04-23 16:11   ` nix.wie.weg
2006-04-24 23:50 ` [Qemu-devel] Update for cvs 2006-04-24 nix.wie.weg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=445408D5.3060101@austin.rr.com \
    --to=lmendez19@austin.rr.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).