From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FadmR-0002u8-An for qemu-devel@nongnu.org; Mon, 01 May 2006 15:09:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FadmQ-0002th-Ii for qemu-devel@nongnu.org; Mon, 01 May 2006 15:09:58 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FadmQ-0002tb-Fu for qemu-devel@nongnu.org; Mon, 01 May 2006 15:09:58 -0400 Received: from [84.96.92.55] (helo=smtP.neuf.fr) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FadqI-00029D-LI for qemu-devel@nongnu.org; Mon, 01 May 2006 15:13:58 -0400 Received: from [84.102.211.147] by sp604004mt.gpm.neuf.ld (Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006)) with ESMTP id <0IYL00FGNMAYZ990@sp604004mt.gpm.neuf.ld> for qemu-devel@nongnu.org; Mon, 01 May 2006 20:06:34 +0200 (CEST) Date: Mon, 01 May 2006 20:05:50 +0200 From: Fabrice Bellard Subject: Re: [Qemu-devel] [PATCH] Fix scrambling of >32KB packets in slirp In-reply-to: <6fe044190605010919q23dcfa19t1d992211c58f679d@mail.gmail.com> Message-id: <44564DFE.8040400@bellard.org> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii; format=flowed Content-transfer-encoding: 7BIT References: <4455EC13.9040000@bellard.org> <6fe044190605010919q23dcfa19t1d992211c58f679d@mail.gmail.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Yes, I would prefer that you resubmit a patch using unsigned types. Fabrice. Kenneth Duda wrote: > Well that is a good question. When I made this patch, I wanted to > respect the comment in the code that the author felt that using a > signed data type was safer in some cases. However, I will admit that > I do not understand this reasoning, and I agree that switching to an > unsigned data type would be better. Would you like us to resubmit > this patch in that form? > > -Ken > > On 5/1/06, Fabrice Bellard wrote: > >> Ed Swierk wrote: >> > In several places in qemu's slirp code, signed and unsigned ints are >> > used interchangeably when dealing with IP packet lengths and offsets. >> > This causes IP packets greater than 32K in length to be scrambled in >> > various interesting ways that are extremely difficult to troubleshoot. >> > >> > Although large IP packets are fairly rare in practice, certain >> > UDP-based protocols like NFS use them extensively. >> > >> > The attached patch wraps IP packet lengths and offsets in macros that >> > ensure they are always properly treated as unsigned values. >> >> Why not changing the definition itself to uint16_t and verifying each >> occurence of ip_off and ip_len ? >> >> Fabrice. >> >> >> _______________________________________________ >> Qemu-devel mailing list >> Qemu-devel@nongnu.org >> http://lists.nongnu.org/mailman/listinfo/qemu-devel >> > > > _______________________________________________ > Qemu-devel mailing list > Qemu-devel@nongnu.org > http://lists.nongnu.org/mailman/listinfo/qemu-devel > >