From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fadco-0005b2-4x for qemu-devel@nongnu.org; Mon, 01 May 2006 15:00:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fadcl-0005Zv-UN for qemu-devel@nongnu.org; Mon, 01 May 2006 15:00:01 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fadcl-0005Zj-Ki for qemu-devel@nongnu.org; Mon, 01 May 2006 14:59:59 -0400 Received: from [84.96.92.56] (helo=smTp.neuf.fr) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fadgd-0001W5-Ai for qemu-devel@nongnu.org; Mon, 01 May 2006 15:03:59 -0400 Received: from [84.102.211.147] by sp604003mt.gpm.neuf.ld (Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006)) with ESMTP id <0IYL00JNYORXUQ20@sp604003mt.gpm.neuf.ld> for qemu-devel@nongnu.org; Mon, 01 May 2006 20:59:58 +0200 (CEST) Date: Mon, 01 May 2006 20:59:14 +0200 From: Fabrice Bellard Subject: Re: [Qemu-devel] PATCH: solaris-sparc-slirp fix In-reply-to: <4456525F.3010108@win4lin.com> Message-id: <44565A82.9070700@bellard.org> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii; format=flowed Content-transfer-encoding: 7BIT References: <29349132.1146506373257.JavaMail.root@eastrmwml06.mgt.cox.net> <4456525F.3010108@win4lin.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi, I did not accept your patch for two reasons: 1) You changed the guest vga frame buffer format and I don't think this is what you wanted (it can be useful to emulate VGA on big endian guests though - the current implementation for ppc guests is a hack). What is needed is to swap the host pixel format. 2) You added support for RGB swapping for 8/15/16 depths and I am not sure this is useful. Endianness swapping would be more useful for 15/16 depths. Fabrice. Leonardo E. Reiter wrote: > Ben, > > You can use the patch I posted here recently to get QEMU to fix the BGR > problem internally. It doesn't have to be done at the VNC level - and > in fact, this way, you can use it on the Solaris native X server (or > even SunRays) in 24-bit color mode. I am attaching a new version of the > patch, complete with the detection logic (to make it automatic), against > today's CVS. > > My original post: > > http://lists.gnu.org/archive/html/qemu-devel/2006-04/msg00181.html > > The last (and fast) version: > > http://lists.gnu.org/archive/html/qemu-devel/2006-04/msg00195.html > > An additional hack to get SDL to configure this automatically, without > needing the -bgr option on the command-line: > > http://lists.gnu.org/archive/html/qemu-devel/2006-04/msg00230.html > > Maybe Fabrice or Paul can commit this since I addressed all the original > issues, but have yet to hear feedback on it. It's working fine for > myself and for my customers using SunRays for several weeks now. The > only issue is cirrus VGA in 16-bit mode seems to do some optimization > that bypasses the swapping code. regular VGA or cirrus VGA in 24-bit > mode (on the guest) works fine. > > Regards, > > Leo Reiter > > Ben Taylor wrote: