From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] VLAN and Tap for win32
Date: Sun, 14 May 2006 20:35:37 +0200 [thread overview]
Message-ID: <44677879.3090809@bellard.org> (raw)
In-Reply-To: <000601c6758e$0ffe7ce0$0464a8c0@athlon>
Kazu wrote:
> Hi,
>
> VLAN and Tap patches for win32 are updated. I added handling for wait
> objects.
>
> http://www.h7.dion.ne.jp/~qemu-win/download/qemu-0.8.1-vlan.patch
I don't undertand this patch: the connect() is meant to be non blocking
so the 'socket_wait_event' just after is not correct. The wait for the
connection must be done inside the QEMU main loop as it is done on the
Unix target (connect() on Unix in non blocking mode usually return
EINPROGRESS and we can wait for the connection using select()).
> http://www.h7.dion.ne.jp/~qemu-win/download/qemu-0.8.1-tap.patch
OK for this one. Suppressing all the remaning polling in the win32
version would be good. In particular, it would be good to be able to
wait for network events while waiting for other events.
Regards,
Fabrice.
next prev parent reply other threads:[~2006-05-14 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-12 6:34 [Qemu-devel] [PATCH] VLAN and Tap for win32 Kazu
2006-05-14 18:35 ` Fabrice Bellard [this message]
2006-05-15 14:03 ` Kazu
2006-05-16 9:31 ` Kazu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44677879.3090809@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).