From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1FfLXX-0002sT-5N
	for qemu-devel@nongnu.org; Sun, 14 May 2006 14:42:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1FfLXW-0002rW-M7
	for qemu-devel@nongnu.org; Sun, 14 May 2006 14:42:02 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1FfLXW-0002rG-As
	for qemu-devel@nongnu.org; Sun, 14 May 2006 14:42:02 -0400
Received: from [84.96.92.55] (helo=smtP.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1FfLZl-0001CW-CN
	for qemu-devel@nongnu.org; Sun, 14 May 2006 14:44:21 -0400
Received: from [86.73.70.56] by sp604004mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0IZ900CJ2QCCA021@sp604004mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Sun, 14 May 2006 20:36:13 +0200 (CEST)
Date: Sun, 14 May 2006 20:35:37 +0200
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] [PATCH] VLAN and Tap for win32
In-reply-to: <000601c6758e$0ffe7ce0$0464a8c0@athlon>
Message-id: <44677879.3090809@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii; format=flowed
Content-transfer-encoding: 7BIT
References: <000601c6758e$0ffe7ce0$0464a8c0@athlon>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Kazu wrote:
> Hi,
> 
> VLAN and Tap patches for win32 are updated. I added handling for wait
> objects.
> 
> http://www.h7.dion.ne.jp/~qemu-win/download/qemu-0.8.1-vlan.patch

I don't undertand this patch: the connect() is meant to be non blocking 
so the 'socket_wait_event' just after is not correct. The wait for the 
connection must be done inside the QEMU main loop as it is done on the 
Unix target (connect() on Unix in non blocking mode usually return 
EINPROGRESS and we can wait for the connection using select()).

> http://www.h7.dion.ne.jp/~qemu-win/download/qemu-0.8.1-tap.patch

OK for this one. Suppressing all the remaning polling in the win32 
version would be good. In particular, it would be good to be able to 
wait for network events while waiting for other events.

Regards,

Fabrice.