From: David Hildenbrand <david@redhat.com>
To: Michal Marek <mmarek@suse.com>, qemu-devel@nongnu.org
Cc: ebischoff@suse.com, mbenes@suse.cz, famz@redhat.com,
agraf@suse.de, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] target-s390x: Implement stfl and stfle
Date: Fri, 24 Feb 2017 17:28:54 +0100 [thread overview]
Message-ID: <446a10db-d790-d7b4-bff7-2de4b82a7063@redhat.com> (raw)
In-Reply-To: <38f8bb7a-63e6-d718-2f2f-9530bc659040@suse.com>
Am 24.02.2017 um 16:22 schrieb Michal Marek:
> On 2017-02-24 15:51, no-reply@patchew.org wrote:
>> Hi,
>>
>> This series seems to have some coding style problems. See output below for
>> more information:
> [...]
>> === OUTPUT BEGIN ===
>> Checking PATCH 1/1: target-s390x: Implement stfl and stfle...
>> ERROR: braces {} are necessary for all arms of this statement
>> #108: FILE: target/s390x/misc_helper.c:522:
>> + if (need <= len)
>> [...]
>> + else
>> [...]
>
> I was not aware of this coding style requirement. I will wait if I get
> more feedback from humans and resubmit.
>
Yes, QEMU (in contrast to the kernel) always requires {} for
if/else/for/while....
--
Thanks,
David
next prev parent reply other threads:[~2017-02-24 16:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 13:44 [Qemu-devel] [PATCH] target-s390x: Implement stfl and stfle Michal Marek
2017-02-24 14:51 ` no-reply
2017-02-24 15:22 ` Michal Marek
2017-02-24 16:28 ` David Hildenbrand [this message]
2017-02-25 0:05 ` Richard Henderson
2017-02-25 20:39 ` Michal Marek
2017-02-25 23:30 ` Michal Marek
2017-02-25 23:16 ` [Qemu-devel] [PATCH v2] " Michal Marek
2017-02-25 23:38 ` [Qemu-devel] [PATCH v3] " Michal Marek
2017-02-26 11:22 ` Thomas Huth
2017-02-26 18:57 ` Michal Marek
2017-02-27 7:30 ` Thomas Huth
2017-02-27 10:18 ` [Qemu-devel] [PATCH v4] " Michal Marek
2017-02-28 22:11 ` Richard Henderson
2017-03-01 8:00 ` Thomas Huth
2017-03-01 19:30 ` Richard Henderson
2017-03-01 20:20 ` Thomas Huth
2017-03-02 13:09 ` David Hildenbrand
2017-03-02 10:53 ` Michal Marek
2017-03-02 13:12 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446a10db-d790-d7b4-bff7-2de4b82a7063@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=ebischoff@suse.com \
--cc=famz@redhat.com \
--cc=mbenes@suse.cz \
--cc=mmarek@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).