From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eo6Nh-0004GF-QL for qemu-devel@nongnu.org; Tue, 20 Feb 2018 06:46:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eo6Ne-0005BM-P3 for qemu-devel@nongnu.org; Tue, 20 Feb 2018 06:46:45 -0500 References: <20180219174231.10874-1-david@redhat.com> <39db6736-b5c5-832f-ffef-1d0a59b85ac2@de.ibm.com> From: David Hildenbrand Message-ID: <446a343e-dd8d-effe-d660-df55fda16a96@redhat.com> Date: Tue, 20 Feb 2018 12:46:23 +0100 MIME-Version: 1.0 In-Reply-To: <39db6736-b5c5-832f-ffef-1d0a59b85ac2@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFCv2] s390x/sclp: remove memory hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , qemu-s390x@nongnu.org Cc: qemu-devel@nongnu.org, Richard Henderson , Alexander Graf , Cornelia Huck , Halil Pasic , Viktor Mihajlovski , Matthew Rosato On 20.02.2018 12:18, Christian Borntraeger wrote: > Given that we have trouble modeling this properly I somewhat like the i= dea. > We should have never folded this into the common code memory hotplug=20 > infrastructure as it is different. Instead we really should have provid= ed > a different interface and we should have build it with migration suppor= t.=20 >=20 > If we need it again in the future, we can certainly add it back via an=20 > s390 specific interface. >=20 Thinking out load (stuff we could to in the future): We could model ordinary memory (-m XG) using standby memory. But instead of creating and deleting memory regions, work on a single huge one (just as now). (using compat machines to control behavior) What would be the optimization? When the guest tells us to unassign memory, we can simply madv(free) that memory. That means if the guest unplugs(offlines) memory, we can actually free the backing storage. This way it acts somewhat like a balloon - but also gets rid of struct pages in the guest. Of course, this would still not be real memory hot(un)plug, as there is no way to control it from the outside. Just a possible optimization. --=20 Thanks, David / dhildenb