Re: [PATCH] bsd-user: add option to enable plugins

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 1/4/25 16:59, Pierrick Bouvier wrote:
> On 4/1/25 07:44, Philippe Mathieu-Daudé wrote:
>> On 1/4/25 16:33, Pierrick Bouvier wrote:
>>> On 3/31/25 23:15, Philippe Mathieu-Daudé wrote:
>>>> Hi Pierrick,
>>>>
>>>> On 1/4/25 01:42, Pierrick Bouvier wrote:
>>>>> Nothing prevent plugins to be enabled on this platform for user
>>>>> binaries, only the option in the driver is missing.
>>>>
>>>> Per commit 903e870f245 ("plugins/api: split out binary
>>>> path/start/end/entry code") this is deliberate:
>>>>
>>>>        The BSD user-mode command line is still missing -plugin.
>>>>        This can be enabled once we have reliable check-tcg tests
>>>>        working for the BSDs.
>>>>
>>>> Should we enable this without test harnessing?
>>>>
>>>
>>> Thanks for pointing this.
>>>
>>> However, I don't get the argument, as the same could be said about
>>> system mode, which runs on BSD also, and already has plugins enabled.
>>> The coupling between user related code and plugins is very low (just
>>> options parsing and init code), so I don't see why we could have a bug
>>> related to a specific platform only for user binaries.
>>>
>>> So either we deactivate plugins completely for bsd binaries, or we take
>>> a leap of faith that it works for them.
>>>
>>> @Alex, any further insight on this?
>>>
>>>>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>>>>> ---
>>>>>     bsd-user/main.c | 12 ++++++++++++
>>>>>     1 file changed, 12 insertions(+)
>>>>
>>>> Ideally we'd have helpers for common user code in common-user/...
>>>>
>>>
>>> Everything is already common for plugins, except adding the call to
>>> plugin command line option parsing function.
>>
>> Yeah, I mean the rest of main() ;)
>>
> 
> It's not a priority at the moment, and not blocking anything on our 
> path, but yes, it would be nice to share more ideally.

Just to be clear, I was not asking you to do that suggestion.

>>>> Anyway, since this patch does what it says:
>>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>>>
>>>
>>> Thanks,
>>> Pierrick
>>>
>>
>