From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>,
Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH 08/12] tests/9pfs: refactor test names and test devices
Date: Thu, 01 Oct 2020 17:26:13 +0200 [thread overview]
Message-ID: <4474985.DjIeONRcyu@silver> (raw)
In-Reply-To: <bbfcbc42-a7f4-926f-78ef-badcb7c023af@redhat.com>
On Donnerstag, 1. Oktober 2020 16:04:39 CEST Paolo Bonzini wrote:
> >> You're right, this is in fact also a problem for virtio-blk and virtio-
net:
> >> /* FIXME: every test using these two nodes needs to setup a
> >>
> >> * -drive,id=drive0 otherwise QEMU is not going to start.
> >> * Therefore, we do not include "produces" edge for virtio
> >> * and pci-device yet.
> >>
> >> */
> >>
> >> /* FIXME: every test using these nodes needs to setup a
> >>
> >> * -netdev socket,id=hs0 otherwise QEMU is not going to start.
> >> * Therefore, we do not include "produces" edge for virtio
> >> * and pci-device yet.
> >> */
> >>
> >> I still think we should do it like this, because it's closer to the way
> >> that libqos will work long term.
> >
> > Could you please elaborate why that long term plan bites with the working
> > solution I provided? [patches 1 and 2]
>
> Because the long term plan is to have a socket/plug mechanism for
> backends where the device can provide a default backend to plug.
Ok, obviously I don't know the details of that future socket/plug plan, but
what I could also imagine for the long-term: allowing to optionally define
'config' nodes as subnodes of devices. Maybe that's similar to what you had in
mind with that socket/plug model.
> The suggested solution is all good for *a different use case*, namely to
> test the same device with different options. It is just wrong for the
> purpose of selecting a frontend.
>
> It occurred to me that you could also add a default backend to the
> command line with "-fsdev" (in the libqos driver), and use -set in the
> test to override it. This is ugly (-set is ugly!) but it would let you
> keep the tests, so it would probably be the best solution.
Ok, I'll have a look at that '*-set' alternative tomorrow.
But on doubt: I will simply disable those the implied pci and virtio tests for
the time being.
I need the 'local' backend tests and have to move on; they are of much more
value than those 2 implied pci and virtio tests.
Best regards,
Christian Schoenebeck
next prev parent reply other threads:[~2020-10-01 15:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 10:43 [PATCH 00/12] 9pfs: add tests using local fs driver Christian Schoenebeck
2020-09-27 10:38 ` [PATCH 01/12] tests/qtest/qgraph: add qemu_name to QOSGraphNode Christian Schoenebeck
2020-09-27 10:39 ` [PATCH 02/12] tests/qtest/qgraph: add qos_node_create_driver_named() Christian Schoenebeck
2020-09-27 10:39 ` [PATCH 03/12] tests/qtest/qos: add qos_dump_graph() Christian Schoenebeck
2020-09-27 10:39 ` [PATCH 04/12] tests/qtest/qos-test: new QTEST_DUMP_GRAPH environment variable Christian Schoenebeck
2020-09-27 10:39 ` [PATCH 05/12] tests/qtest/qos-test: add QTEST_DUMP_ENV " Christian Schoenebeck
2020-09-27 10:40 ` [PATCH 06/12] tests/qtest/qos-test: add environment variable QTEST_DEBUG Christian Schoenebeck
2020-09-28 8:31 ` Paolo Bonzini
2020-09-28 12:11 ` Christian Schoenebeck
2020-09-27 10:40 ` [PATCH 07/12] test/9pfs: change export tag name to qtest-synth Christian Schoenebeck
2020-09-27 10:40 ` [PATCH 08/12] tests/9pfs: refactor test names and test devices Christian Schoenebeck
2020-09-28 8:36 ` Paolo Bonzini
2020-09-28 8:37 ` Paolo Bonzini
2020-09-28 11:56 ` Christian Schoenebeck
2020-09-28 12:42 ` Paolo Bonzini
2020-09-28 13:35 ` Christian Schoenebeck
2020-09-28 16:38 ` Paolo Bonzini
2020-10-01 11:34 ` Christian Schoenebeck
2020-10-01 11:56 ` Paolo Bonzini
2020-10-01 12:15 ` Christian Schoenebeck
2020-10-01 14:04 ` Paolo Bonzini
2020-10-01 15:26 ` Christian Schoenebeck [this message]
2020-09-27 10:40 ` [PATCH 09/12] tests/9pfs: introduce local tests Christian Schoenebeck
2020-09-27 10:41 ` [PATCH 10/12] tests/9pfs: wipe local 9pfs test directory Christian Schoenebeck
2020-09-27 10:41 ` [PATCH 11/12] tests/9pfs: add virtio_9p_test_path() Christian Schoenebeck
2020-09-27 10:41 ` [PATCH 12/12] tests/9pfs: add local Tmkdir test Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4474985.DjIeONRcyu@silver \
--to=qemu_oss@crudebyte.com \
--cc=e.emanuelegiuseppe@gmail.com \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).