From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FncLc-0001F4-AW for qemu-devel@nongnu.org; Tue, 06 Jun 2006 10:15:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FncLZ-0001Ej-PM for qemu-devel@nongnu.org; Tue, 06 Jun 2006 10:15:55 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FncLZ-0001Eg-Ju for qemu-devel@nongnu.org; Tue, 06 Jun 2006 10:15:53 -0400 Received: from [216.148.227.154] (helo=rwcrmhc14.comcast.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FncSx-0005m4-AT for qemu-devel@nongnu.org; Tue, 06 Jun 2006 10:23:31 -0400 Message-ID: <44858E12.2030803@win4lin.com> Date: Tue, 06 Jun 2006 10:15:46 -0400 From: "Leonardo E. Reiter" MIME-Version: 1.0 Subject: Re: [Qemu-devel] [Patch] Kqemu patch for 2.6.17-rc2 References: <20060510234101.55cb336b@crazy.kos.nx> In-Reply-To: <20060510234101.55cb336b@crazy.kos.nx> Content-Type: multipart/mixed; boundary="------------040506050405000807020905" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------040506050405000807020905 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, I'm attaching a small update to Thomas's patch which conditionally enables this based on kernel version. As far as I can tell (from very brief research), module_param became available very late in 2.4. Also, the old version (MODULE_PARM) is supported in most 2.6 kernels as well. I picked arbitrarily 2.6.10 as the break-off point - it's really easy to change that to be something else. In any case, Fabrice, can you think about applying this, or something very similar, as it looks like MODULE_PARM has been finally abandoned in the latest kernels. Regards, Leo Reiter Thomas Petazzoni wrote: > Hi, > > On 2.6.17-rc2, the MODULE_PARM() way of declaring module parameters > seems to have disappeared (it is anyway deprecated since the beginning > of the 2.6 series). As such, kqemu-1.3.0pre7 doesn't compile. -- Leonardo E. Reiter Vice President of Product Development, CTO Win4Lin, Inc. Virtual Computing that means Business Main: +1 512 339 7979 Fax: +1 512 532 6501 http://www.win4lin.com --------------040506050405000807020905 Content-Type: text/x-patch; name="kqemu-linux-module-param.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="kqemu-linux-module-param.diff" --- kqemu-linux.c.orig 2006-06-06 10:06:03.000000000 -0400 +++ kqemu-linux.c 2006-06-06 10:09:41.000000000 -0400 @@ -49,7 +49,11 @@ /* if 0 is used, then devfs/udev is used to automatically create the device */ int major = 250; +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,10) MODULE_PARM(major,"i"); +#else +module_param(major, int, 0); +#endif /* Lock the page at virtual address 'user_addr' and return its physical address (page index). Return a host OS private user page --------------040506050405000807020905--