From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fo4k1-0001M2-KZ for qemu-devel@nongnu.org; Wed, 07 Jun 2006 16:35:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fo4jz-0001Kx-7G for qemu-devel@nongnu.org; Wed, 07 Jun 2006 16:35:00 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fo4jz-0001Ku-4F for qemu-devel@nongnu.org; Wed, 07 Jun 2006 16:34:59 -0400 Received: from [24.25.9.103] (helo=ms-smtp-04.southeast.rr.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fo4re-0001D0-JE for qemu-devel@nongnu.org; Wed, 07 Jun 2006 16:42:54 -0400 Received: from homepc.nigelterry.net (cpe-024-211-173-112.nc.res.rr.com [24.211.173.112]) by ms-smtp-04.southeast.rr.com (8.13.6/8.13.6) with ESMTP id k57KYsuS002046 for ; Wed, 7 Jun 2006 16:34:54 -0400 (EDT) Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by homepc.nigelterry.net (8.13.6/8.13.6) with ESMTP id k57KYsFZ025818 for ; Wed, 7 Jun 2006 16:34:54 -0400 Message-ID: <4487386D.80603@nigelterry.net> Date: Wed, 07 Jun 2006 16:34:53 -0400 From: "Nigel J. Terry" MIME-Version: 1.0 Subject: Re: [Qemu-devel] [Patch] Kqemu patch for 2.6.17-rc2 References: <20060510234101.55cb336b@crazy.kos.nx> <44858E12.2030803@win4lin.com> In-Reply-To: <44858E12.2030803@win4lin.com> Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Leonardo E. Reiter wrote:

Hi,

I'm attaching a small update to Thomas's patch which conditionally enables this based on kernel version. As far as I can tell (from very brief research), module_param became available very late in 2.4. Also, the old version (MODULE_PARM) is supported in most 2.6 kernels as well. I picked arbitrarily 2.6.10 as the break-off point - it's really easy to change that to be something else. In any case, Fabrice, can you think about applying this, or something very similar, as it looks like MODULE_PARM has been finally abandoned in the latest kernels.

Regards,

Leo Reiter

Thomas Petazzoni wrote:

Hi,

On 2.6.17-rc2, the MODULE_PARM() way of declaring module parameters
seems to have disappeared (it is anyway deprecated since the beginning
of the 2.6 series). As such, kqemu-1.3.0pre7 doesn't compile.
--- kqemu-linux.c.orig	2006-06-06 10:06:03.000000000 -0400
+++ kqemu-linux.c	2006-06-06 10:09:41.000000000 -0400
@@ -49,7 +49,11 @@
 /* if 0 is used, then devfs/udev is used to automatically create the
    device */
 int major = 250;
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,10)
 MODULE_PARM(major,"i");
+#else
+module_param(major, int, 0);
+#endif
 
 /* Lock the page at virtual address 'user_addr' and return its
    physical address (page index). Return a host OS private user page
  
  

I have just had to apply this fix to get kqemu to work with the latest FC6 Development kernel 2.6.16-1.2252_FC6. ALl working fine now.

Nigel