qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Peter Maydell" <peter.maydell@linaro.org>,
	"Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-stable <qemu-stable@nongnu.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again
Date: Wed, 18 Apr 2018 15:49:43 +0200	[thread overview]
Message-ID: <448a7d28-0ccd-28a7-9dfd-a729678f2785@redhat.com> (raw)
In-Reply-To: <CAFEAcA-2kTYvJYWwsBwYHv+45y32uPYj+2Ut9VnZhTQwsKyhDQ@mail.gmail.com>

On 18/04/2018 14:06, Peter Maydell wrote:
> 
>> In case of a mux chardev, it may already
>> have an active frontend (yeah be is CharBackend which is the frontend,
>> I still can't grasp that either, please Paolo change your mind! ;).
> I agree with Marc-André that the terminology for our chardev
> code is hopelessly confusing. The things that are logically
> backends (file, stdio, etc) are called "chardevs", and the
> thing that is called the CharBackend is, well, I don't know
> what it is. include/chardev/char.h has a helpful comment:
>      /* character device */
>      typedef struct CharBackend CharBackend;
> 
> The doc comments for functions like qemu_chr_new() that return
> a Chardev* say they "create a new character backend".
> 
> And then there's ChardevBackend, which is something else again.

Since CharBackend was named like that for consistency with BlockBackend,
ChardevBackend could be changed to ChardevOptions and
CHARDEV_BACKEND_KIND_* to CHARDEV_DRIVER_*.  That would be a good idea
indeed.

Paolo

  reply	other threads:[~2018-04-18 13:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16 18:18 [Qemu-devel] [PATCH] mux: fix ctrl-a b again Marc-André Lureau
2018-04-16 18:28 ` Peter Maydell
2018-04-16 18:44   ` Daniel P. Berrangé
2018-04-17 12:51     ` Peter Maydell
2018-04-17 18:36       ` Philippe Mathieu-Daudé
2018-04-17 20:07         ` Peter Maydell
2018-04-17 21:19         ` Peter Maydell
2018-04-17 21:33           ` Marc-André Lureau
2018-04-18 10:36         ` Marc-André Lureau
2018-04-18 10:55           ` Paolo Bonzini
2018-04-18 11:35             ` Marc-André Lureau
2018-04-18 11:55               ` Paolo Bonzini
2018-04-18 12:22                 ` Marc-André Lureau
2018-04-18 13:47                   ` Paolo Bonzini
2018-04-18 14:01                     ` Marc-André Lureau
2018-04-18 12:06           ` Peter Maydell
2018-04-18 13:49             ` Paolo Bonzini [this message]
2018-04-18 14:32           ` Philippe Mathieu-Daudé
2018-04-18 14:38             ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=448a7d28-0ccd-28a7-9dfd-a729678f2785@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=marcandre.lureau@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).