qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] Patch: Fix rip-relative addressing for SSE compare
@ 2006-06-04  0:31 Robin Green
  2006-06-14 14:29 ` Fabrice Bellard
  0 siblings, 1 reply; 2+ messages in thread
From: Robin Green @ 2006-06-04  0:31 UTC (permalink / raw)
  To: qemu-devel

This patch corrects a bug with rip-relative addressing for some SSE
compare instructions on x86_64. This makes GNU wget work on x86_64.
-- 
Robin

Index: target-i386/translate.c
===================================================================
RCS file: /sources/qemu/qemu/target-i386/translate.c,v
retrieving revision 1.56
diff -u -b -r1.56 translate.c
--- target-i386/translate.c     24 Apr 2006 20:14:56 -0000      1.56
+++ target-i386/translate.c     4 Jun 2006 00:22:25 -0000
@@ -2990,6 +2990,8 @@
                     gen_op_andl_A0_ffff();
             }
             gen_add_A0_ds_seg(s);
+       } else if (b == 0xc2) {
+           s->rip_offset++;
         }
         if (is_xmm) {
             op1_offset = offsetof(CPUX86State,xmm_regs[reg]);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] Patch: Fix rip-relative addressing for SSE compare
  2006-06-04  0:31 [Qemu-devel] Patch: Fix rip-relative addressing for SSE compare Robin Green
@ 2006-06-14 14:29 ` Fabrice Bellard
  0 siblings, 0 replies; 2+ messages in thread
From: Fabrice Bellard @ 2006-06-14 14:29 UTC (permalink / raw)
  To: qemu-devel

Robin Green wrote:
> This patch corrects a bug with rip-relative addressing for some SSE
> compare instructions on x86_64. This makes GNU wget work on x86_64.

I made a more complete fix. Tell me if it works on your examples.

Fabrice.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-06-14 14:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-04  0:31 [Qemu-devel] Patch: Fix rip-relative addressing for SSE compare Robin Green
2006-06-14 14:29 ` Fabrice Bellard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).