From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1FsSn0-00062z-JW
	for qemu-devel@nongnu.org; Mon, 19 Jun 2006 19:04:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1FsSmz-00062b-H3
	for qemu-devel@nongnu.org; Mon, 19 Jun 2006 19:04:14 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1FsSmz-00062Y-EU
	for qemu-devel@nongnu.org; Mon, 19 Jun 2006 19:04:13 -0400
Received: from [84.96.92.56] (helo=smTp.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1FsSxN-000150-Q4
	for qemu-devel@nongnu.org; Mon, 19 Jun 2006 19:14:57 -0400
Received: from [84.102.211.138] by sp604003mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0J1400FOSQ7CI3Q1@sp604003mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Tue, 20 Jun 2006 00:52:24 +0200 (CEST)
Date: Tue, 20 Jun 2006 00:52:08 +0200
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] [PATCH] mips-user socket-related syscall support
In-reply-to: <449667B1.5070300@twilight-hall.net>
Message-id: <44972A98.6060905@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: QUOTED-PRINTABLE
References: <449667B1.5070300@twilight-hall.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: ml-qemu@twilight-hall.net
Cc: qemu-devel@nongnu.org

Another point is that doing:

+    target_long args[6];
+
+    tputl(args, arg1);
+    tputl(args+1, arg2);
+    tputl(args+2, arg3);
+    tputl(args+3, arg4);
+    tputl(args+4, arg5);
+    tputl(args+5, arg6);

at the start of every syscall is not acceptable. You should add a=
=20
specific socket call wrapper which takes arg1... arg6 as arguments.

Regards,

Fabrice.

Rapha=EBl Rigo wrote:
> Hello,
> this patch is a revamped version of the one I posted about 2 months=
 ago,
> it is much better. It implements the syscalls related to sockets on=
 the
> MIPS platform (because it has no "socketcall" syscall). I had to cr=
eate
> a "socket.h" file defining the constants for the targets because MI=
PS
> doesn't have the same as every other platform.
>=20
> The calls implemented are : accept, bind, connect, getpeername,
> getsockname, listen, recv, recvfrom, recvmsg, send, sendmsg, sendto=
,
> shutdown, socket, socketpair.
>=20
> Combined with the other patch I just posted (signal handling), qemu=
-mips
> is now capable of running a webserver (which is very nice :)
>=20
> Please consider it for inclusion into mainline.
>=20
> Rapha=EBl Rigo