From: Fabrice Bellard <fabrice@bellard.org>
To: "Raphaël Rigo" <ml-qemu@twilight-hall.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] mips-user socket-related syscall support
Date: Sat, 24 Jun 2006 17:08:41 +0200 [thread overview]
Message-ID: <449D5579.4000404@bellard.org> (raw)
In-Reply-To: <449ACFF6.3050704@twilight-hall.net>
Raphaël Rigo wrote:
> Raphaël Rigo wrote:
>
>>Fabrice Bellard wrote:
>>
>>>Another point is that doing:
>>>
>>>+ target_long args[6];
>>>+
>>>+ tputl(args, arg1);
>>>+ tputl(args+1, arg2);
>>>+ tputl(args+2, arg3);
>>>+ tputl(args+3, arg4);
>>>+ tputl(args+4, arg5);
>>>+ tputl(args+5, arg6);
>>>
>>>at the start of every syscall is not acceptable. You should add a
>>>specific socket call wrapper which takes arg1... arg6 as arguments.
>>>
>>>Regards,
>>>
>>>Fabrice.
>>
>>Thanks for reviewing it, the new attached version should be much cleaner.
>>
>>Regards,
>>Raphaël
>
> Sorry to insist, but can you please include it in the CVS? I really think it's
> useful.
I applied it and added "getsockopt". In fact, you should completely
suppress do_socketcallwrapper() (using tputl and tgetl for non user
access is bad).
Regards,
Fabrice.
prev parent reply other threads:[~2006-06-24 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-19 9:00 [Qemu-devel] [PATCH] mips-user socket-related syscall support Raphaël Rigo
2006-06-19 22:03 ` Fabrice Bellard
2006-06-20 6:54 ` Raphaël Rigo
2006-06-20 8:28 ` Thiemo Seufer
2006-06-19 22:52 ` Fabrice Bellard
2006-06-20 8:47 ` Raphaël Rigo
2006-06-22 17:14 ` Raphaël Rigo
2006-06-24 15:08 ` Fabrice Bellard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449D5579.4000404@bellard.org \
--to=fabrice@bellard.org \
--cc=ml-qemu@twilight-hall.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).