From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Fu9l4-0005vK-9Y
	for qemu-devel@nongnu.org; Sat, 24 Jun 2006 11:09:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Fu9l3-0005uj-42
	for qemu-devel@nongnu.org; Sat, 24 Jun 2006 11:09:13 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Fu9l2-0005ue-TV
	for qemu-devel@nongnu.org; Sat, 24 Jun 2006 11:09:12 -0400
Received: from [84.96.92.61] (helo=sMtp.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fu9wU-0003C1-Br
	for qemu-devel@nongnu.org; Sat, 24 Jun 2006 11:21:02 -0400
Received: from [84.102.211.206] by sp604002mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0J1D000NHE2TARG0@sp604002mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Sat, 24 Jun 2006 17:08:54 +0200 (CEST)
Date: Sat, 24 Jun 2006 17:08:41 +0200
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] [PATCH] mips-user socket-related syscall support
In-reply-to: <449ACFF6.3050704@twilight-hall.net>
Message-id: <449D5579.4000404@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: QUOTED-PRINTABLE
References: <449667B1.5070300@twilight-hall.net> <44972A98.6060905@bellard.org>
	<4497B611.30809@twilight-hall.net> <449ACFF6.3050704@twilight-hall.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Rapha=EBl_Rigo?= <ml-qemu@twilight-hall.net>
Cc: qemu-devel@nongnu.org

Rapha=EBl Rigo wrote:
> Rapha=EBl Rigo wrote:
>=20
>>Fabrice Bellard wrote:
>>
>>>Another point is that doing:
>>>
>>>+    target_long args[6];
>>>+
>>>+    tputl(args, arg1);
>>>+    tputl(args+1, arg2);
>>>+    tputl(args+2, arg3);
>>>+    tputl(args+3, arg4);
>>>+    tputl(args+4, arg5);
>>>+    tputl(args+5, arg6);
>>>
>>>at the start of every syscall is not acceptable. You should add a
>>>specific socket call wrapper which takes arg1... arg6 as arguments=
.
>>>
>>>Regards,
>>>
>>>Fabrice.
>>
>>Thanks for reviewing it, the new attached version should be much cl=
eaner.
>>
>>Regards,
>>Rapha=EBl
>=20
> Sorry to insist, but can you please include it in the CVS? I really=
 think it's
> useful.

I applied it and added "getsockopt". In fact, you should completely=
=20
suppress do_socketcallwrapper() (using tputl and tgetl for non user=
=20
access is bad).

Regards,

Fabrice.