From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1FvLQY-0005a3-IM
	for qemu-devel@nongnu.org; Tue, 27 Jun 2006 17:48:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1FvLQX-0005Zq-1U
	for qemu-devel@nongnu.org; Tue, 27 Jun 2006 17:48:57 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1FvLQW-0005Zn-VS
	for qemu-devel@nongnu.org; Tue, 27 Jun 2006 17:48:56 -0400
Received: from [84.96.92.56] (helo=smTp.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1FvLci-0002jo-7T
	for qemu-devel@nongnu.org; Tue, 27 Jun 2006 18:01:32 -0400
Received: from [84.99.204.155] by sp604003mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0J1J00AO7EQG96G0@sp604003mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Tue, 27 Jun 2006 23:08:40 +0200 (CEST)
Date: Tue, 27 Jun 2006 23:08:29 +0200
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] Pending MIPS patches
In-reply-to: <44A018E4.50708@twilight-hall.net>
Message-id: <44A19E4D.2090005@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: QUOTED-PRINTABLE
References: <449EB5FA.6070405@gmail.com> <449EBC39.3050701@bellard.org>
	<44A001C7.8040303@gmail.com> <44A018E4.50708@twilight-hall.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Rapha=EBl_Rigo?= <ml-qemu@twilight-hall.net>
Cc: qemu-devel@nongnu.org

Rapha=EBl Rigo wrote:
> Dirk Behme wrote:
>=20
>> Hi Rapha=EBl,
>>
>> maybe you find some time and like to answer to Fabrice's remark=
=20
>> regarding patch 8
>> below?
>>
>> http://lists.gnu.org/archive/html/qemu-devel/2006-06/msg00419.html
>>
>> Would be nice to get as many of the pending MIPS patches applied a=
s=20
>> possible.
>>
>> Many thanks
>>
>> Dirk
>>
>> Fabrice Bellard wrote:
>>
>>>> Pending MIPS patches (bugs & improvements):
>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
>>
>>
>>>> 8. [PATCH] Add mips-user signal handling
>>>> http://lists.gnu.org/archive/html/qemu-devel/2006-06/msg00319.ht=
ml
>>>
>>>
>>>
>>> OK. Need to check the handling of "env->PC +=3D 4" in=20
>>> linux-user/main.c. I want to be sure there is not a better soluti=
on.=20
>>> Adding setup_rt_frame would be good too.
>=20
> Hello,
> there are 2 possibilities to handle this env->PC +=3D 4:
>    -    do a special case wrapper here to avoid increasing PC when =
it's=20
> a sigreturn.
>    -    in do_sigreturn set PC with a -4 offset.
> I chose the first way because I thought it would be cleaner, if any=
one=20
> was to change this part of the code, then it would be clear that=
=20
> sigreturn directly sets PC. Using the 2nd possibility, one could ch=
ange=20
> this +=3D 4 without knowing do_sigreturn would be affected.
>=20
> I also checked if we could get rid of this weird piece of code, but=
=20
> could not find a clear way to do so.
>=20
> So i preferred maintainability over efficiency, but if you think
> setting PC with an offset of -4 in signal.c is better, tell me and =
i=20
> will update the patch.

There is another simpler solution and I applied it. BTW, the Linux=
=20
kernel uses the same solution :-)

Fabrice.