From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fx1Gy-0006Ug-Ld for qemu-devel@nongnu.org; Sun, 02 Jul 2006 08:42:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fx1Gx-0006Ts-8l for qemu-devel@nongnu.org; Sun, 02 Jul 2006 08:41:59 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fx1Gx-0006To-22 for qemu-devel@nongnu.org; Sun, 02 Jul 2006 08:41:59 -0400 Received: from [147.11.1.11] (helo=mail.wrs.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fx1UA-0006hK-Lr for qemu-devel@nongnu.org; Sun, 02 Jul 2006 08:55:39 -0400 Received: from ala-mail04.corp.ad.wrs.com (ala-mail04 [147.11.57.145]) by mail.wrs.com (8.13.6/8.13.3) with ESMTP id k62CfvN7002997 for ; Sun, 2 Jul 2006 05:41:57 -0700 (PDT) Message-ID: <44A7BF14.4010406@windriver.com> Date: Sun, 02 Jul 2006 07:41:56 -0500 From: Jason Wessel MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] add serial port mux for debug monitor support References: <44A6D9E1.3040104@windriver.com> In-Reply-To: <44A6D9E1.3040104@windriver.com> Content-Type: multipart/mixed; boundary="------------020605030304000506010408" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------020605030304000506010408 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Following up to my last patch, I noticed a break; statement was missing and cause a bit of a problem with the -echr option. Fix is attached. signed-off-by: jason.wessel@windriver.com Jason Wessel wrote: > There are two patches attached to show the logical progress of the > code and in the case that one is not accepted the work is more easily > broken down. > > The serial_mux_driver.patch must be applied first. It adds a generic > mux support for the I/O drivers internal to vl.c. The main purpose is > to use it for switching on the monitor. Basically it allows more than > one driver to register an fd_read and fd_can_read routine. Of course > the mux support is generic and could easily be used for other sorts of > I/O. This patch also adds the new options: > > -echr ascii_value -- Allow you to use a different control character > other than Control-a > -serial mon:device_string -- Multiplex the device_string with the > monitor functionality > > The second patch fully abstracts the monitor so that the monitor can > be used on more than one serial port at the same time as well as > having a separate dedicated monitor. I also removed the stdio > splitting from the stdio driver. The mux driver can be used to > replace any functionality that I missed. > > signed-off-by: jason.wessel@windriver.com > > Jason. --------------020605030304000506010408 Content-Type: text/plain; name="missing_break.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="missing_break.patch" Index: qemu/vl.c =================================================================== --- qemu.orig/vl.c +++ qemu/vl.c @@ -6036,6 +6036,7 @@ int main(int argc, char **argv) term_escape_char = strtol(optarg, &r, 0); if (r == optarg) printf("Bad argument to echr\n"); + break; } case QEMU_OPTION_monitor: pstrcpy(monitor_device, sizeof(monitor_device), optarg); --------------020605030304000506010408--