From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1G5LxV-0005dj-3P
	for qemu-devel@nongnu.org; Tue, 25 Jul 2006 08:24:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1G5LxU-0005cx-FG
	for qemu-devel@nongnu.org; Tue, 25 Jul 2006 08:24:20 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1G5LxU-0005cl-BV
	for qemu-devel@nongnu.org; Tue, 25 Jul 2006 08:24:20 -0400
Received: from [70.116.9.243] (helo=localhost.localdomain)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32)
	(Exim 4.52) id 1G5Lyn-00046W-Hs
	for qemu-devel@nongnu.org; Tue, 25 Jul 2006 08:25:41 -0400
Message-ID: <44C60D47.2060906@codemonkey.ws>
Date: Tue, 25 Jul 2006 07:23:35 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <E42673822206994F8293A048721B91A506135E@pdsmsx412.ccr.corp.intel.com>
In-Reply-To: <E42673822206994F8293A048721B91A506135E@pdsmsx412.ccr.corp.intel.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH]some vnc enhancement
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Yang, Xiaowei" <xiaowei.yang@intel.com>
Cc: qemu-devel@nongnu.org

Hi Xiaowei,

Fabrice had mentioned some interest in refactoring some of the SDL code 
so that the VC switching was shared between VNC/SDL.  Not sure quite 
what he was thinking so hopefully he'll chime in.

The only issue I see in the patch is that you're using the XK_ symbols.  
I purposefully didn't rely on those since they aren't available on Win32 
and the VNC spec is suggests that the actual value of these symbols can 
vary greatly on different platforms (especially the control keys).

Regards,

Anthony Liguori

Yang, Xiaowei wrote:
> Qemu 0.8 uses a written-from-scratch VNC implementation, which lacks of
> some original features. One thing is that it doesn't recognize
> ctrl+alt+1/2/3 to switch among screens. Another issue is VNC client may
> reset color depth after connection, so if we don't re-calculate
> color_table, monitor/console's background is abnormal. I made a patch to
> add them. 
>
> Thanks,
> Xiaowei
>