qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Fix warnings in mips_r4k.c
Date: Mon, 31 Jul 2006 12:20:18 +0200	[thread overview]
Message-ID: <44CDD962.7020900@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]


Fix warnings

hw/mips_r4k.c: In function  ‘mips_r4kc_init’:
hw/mips_r4k.c:230: warning: pointer targets in passing
argument 3 of ‘load_elf’ differ in signedness
hw/mips_r4k.c:256: warning: pointer targets in passing
argument 1 of ‘strcpy’ differ in signedness


[-- Attachment #2: mips_r4k_warning.patch --]
[-- Type: text/x-patch, Size: 810 bytes --]

--- ./hw/mips_r4k.c_orig	2006-07-31 12:11:32.000000000 +0200
+++ ./hw/mips_r4k.c	2006-07-31 12:14:55.000000000 +0200
@@ -195,7 +195,7 @@ void mips_r4kc_init (int ram_size, int v
                      const char *initrd_filename)
 {
     char buf[1024];
-    int64_t entry = 0;
+    uint64_t entry = 0;
     unsigned long bios_offset;
     int io_memory;
     int ret;
@@ -253,7 +253,7 @@ void mips_r4kc_init (int ram_size, int v
         }
 
 	/* Store command line.  */
-        strcpy (phys_ram_base + (16 << 20) - 256, kernel_cmdline);
+        strcpy ((char *)phys_ram_base + (16 << 20) - 256, kernel_cmdline);
         /* FIXME: little endian support */
         *(int *)(phys_ram_base + (16 << 20) - 260) = tswap32 (0x12345678);
         *(int *)(phys_ram_base + (16 << 20) - 264) = tswap32 (ram_size);


             reply	other threads:[~2006-07-31 10:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-31 10:20 Dirk Behme [this message]
2006-07-31 12:39 ` [Qemu-devel] [PATCH] Fix warnings in mips_r4k.c Paul Brook
2006-07-31 13:18   ` Dirk Behme
2006-07-31 13:33     ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44CDD962.7020900@gmail.com \
    --to=dirk.behme@googlemail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).