From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] lance.c emulation corrections
Date: Sat, 12 Aug 2006 13:57:36 +0200 [thread overview]
Message-ID: <44DDC230.4090406@bellard.org> (raw)
In-Reply-To: <BAY104-F26350AEC83F014E136431FF480@phx.gbl>
Blue Swirl wrote:
>>> It could be worthwhile to check if lance (Am7990) and pcnet (Am79C970A)
>>> drivers could be merged. This was discussed briefly some years ago:
>>> http://lists.gnu.org/archive/html/qemu-devel/2004-10/msg00364.html
>>>
>>
>> Yes, a quick look shows 79c970a has one rx/tx buffer management mode
>> which
>> is software-compatible with 7990 chip (SWMODE=0) There may be more
>> backward-compatibility bits to be unified. Anyone? :)
>
>
> Looks like only 32-bit modes are implemented in pcnet.c and endianness
> issues should be checked.
>
> The files could be reorganised to for example pcnet-common.c,
> pcnet-pci.c, and pcnet-lance.c or just throw everything together with
> small performance penalty and unwanted code for both lance and pcnet.
> Opinions?
Make a single file. It will always be possible to split it if it becomes
too big.
Fabrice.
prev parent reply other threads:[~2006-08-12 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 23:31 [Qemu-devel] [PATCH] lance.c emulation corrections Igor Kovalenko
2006-08-10 16:45 ` Blue Swirl
2006-08-10 18:28 ` Igor Kovalenko
2006-08-12 7:53 ` Blue Swirl
2006-08-12 11:57 ` Fabrice Bellard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44DDC230.4090406@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).