From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1GBs81-0006UP-OH
	for qemu-devel@nongnu.org; Sat, 12 Aug 2006 07:58:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1GBs80-0006UD-5e
	for qemu-devel@nongnu.org; Sat, 12 Aug 2006 07:58:08 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1GBs80-0006UA-11
	for qemu-devel@nongnu.org; Sat, 12 Aug 2006 07:58:08 -0400
Received: from [84.96.92.56] (helo=smTp.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1GBsDL-0006Uh-PV
	for qemu-devel@nongnu.org; Sat, 12 Aug 2006 08:03:39 -0400
Received: from [84.102.211.154] by sp604003mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0J3V00AWZVVNJMS1@sp604003mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Sat, 12 Aug 2006 13:57:23 +0200 (CEST)
Date: Sat, 12 Aug 2006 13:57:36 +0200
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] [PATCH] lance.c emulation corrections
In-reply-to: <BAY104-F26350AEC83F014E136431FF480@phx.gbl>
Message-id: <44DDC230.4090406@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii; format=flowed
Content-transfer-encoding: 7BIT
References: <BAY104-F26350AEC83F014E136431FF480@phx.gbl>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Blue Swirl wrote:
>>> It could be worthwhile to check if lance (Am7990) and pcnet (Am79C970A)
>>> drivers could be merged. This was discussed briefly some years ago:
>>> http://lists.gnu.org/archive/html/qemu-devel/2004-10/msg00364.html
>>>
>>
>> Yes, a quick look shows 79c970a has one rx/tx buffer management mode 
>> which
>> is software-compatible with 7990 chip (SWMODE=0) There may be more
>> backward-compatibility bits to be unified. Anyone? :)
> 
> 
> Looks like only 32-bit modes are implemented in pcnet.c and endianness 
> issues should be checked.
> 
> The files could be reorganised to for example pcnet-common.c, 
> pcnet-pci.c, and pcnet-lance.c or just throw everything together with 
> small performance penalty and unwanted code for both lance and pcnet. 
> Opinions?

Make a single file. It will always be possible to split it if it becomes 
too big.

Fabrice.