From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GFGvd-0002sp-Ba for qemu-devel@nongnu.org; Mon, 21 Aug 2006 17:03:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GFGvb-0002sd-Uy for qemu-devel@nongnu.org; Mon, 21 Aug 2006 17:03:24 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GFGvb-0002sa-QL for qemu-devel@nongnu.org; Mon, 21 Aug 2006 17:03:23 -0400 Received: from [84.96.92.11] (helo=smtp.Neuf.fr) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GFH34-0005uz-Ev for qemu-devel@nongnu.org; Mon, 21 Aug 2006 17:11:06 -0400 Received: from [84.102.211.58] by sp604005mt.gpm.neuf.ld (Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006)) with ESMTP id <0J4D004VN94BD8X0@sp604005mt.gpm.neuf.ld> for qemu-devel@nongnu.org; Mon, 21 Aug 2006 23:02:35 +0200 (CEST) Date: Mon, 21 Aug 2006 23:02:54 +0200 From: Fabrice Bellard Subject: Re: [Qemu-devel][Patch] Fix QEMU failure for disk image on readonly filesystem In-reply-to: <44E9E5F2.7030008@mail.berlios.de> Message-id: <44EA1F7E.1030703@bellard.org> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii; format=flowed Content-transfer-encoding: 7BIT References: <44E9E5F2.7030008@mail.berlios.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stefan Weil wrote: > Hello, > > qemu fails when the disk image file is writable but on > a readonly filesystem (so it is not really writable). > > The patch below fixes this. It also declares a local > function "static" (maybe this part of the patch is a > matter of taste). Are you sure it is needed ? I made a different fix a few days ago. Regards, Fabrice.