From: Fabrice Bellard <fabrice@bellard.org>
To: Blue Swirl <blueswir1@hotmail.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: PCNet & Lance merge
Date: Sun, 27 Aug 2006 13:08:06 +0200 [thread overview]
Message-ID: <44F17D16.6050407@bellard.org> (raw)
In-Reply-To: <BAY104-F159495ED8BA0F9115072F6FF3B0@phx.gbl>
Blue Swirl wrote:
> Hi,
>
> These patches merge PCNet and Lance, implement the new IOMMU access
> method and convert ESP and PCNet to use the new method.
>
> At least Sparc works as before. I think the changes should not change PC
> use of PCNet.
Still one remark: using bswap() is almost surely a bug (what if the host
CPU is big endian ?). For correct code, you must use le16_to_cpu() or
be16_to_cpu().
Regards,
Fabrice.
next prev parent reply other threads:[~2006-08-27 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-27 9:44 [Qemu-devel] PCNet & Lance merge Blue Swirl
2006-08-27 11:08 ` Fabrice Bellard [this message]
2006-08-29 13:32 ` Paul Brook
2006-08-29 16:27 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F17D16.6050407@bellard.org \
--to=fabrice@bellard.org \
--cc=blueswir1@hotmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).