From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1GHIUU-000472-JW
	for qemu-devel@nongnu.org; Sun, 27 Aug 2006 07:07:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1GHIUT-00046U-SB
	for qemu-devel@nongnu.org; Sun, 27 Aug 2006 07:07:46 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1GHIUT-00046M-PM
	for qemu-devel@nongnu.org; Sun, 27 Aug 2006 07:07:45 -0400
Received: from [84.96.92.55] (helo=smtP.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1GHIdB-0007Lb-SY
	for qemu-devel@nongnu.org; Sun, 27 Aug 2006 07:16:46 -0400
Received: from [84.102.211.122] by sp604004mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0J4N003KZLKWM320@sp604004mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Sun, 27 Aug 2006 13:07:44 +0200 (CEST)
Date: Sun, 27 Aug 2006 13:08:06 +0200
From: Fabrice Bellard <fabrice@bellard.org>
In-reply-to: <BAY104-F159495ED8BA0F9115072F6FF3B0@phx.gbl>
Message-id: <44F17D16.6050407@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii; format=flowed
Content-transfer-encoding: 7BIT
References: <BAY104-F159495ED8BA0F9115072F6FF3B0@phx.gbl>
Subject: [Qemu-devel] Re: PCNet & Lance merge
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blueswir1@hotmail.com>
Cc: qemu-devel@nongnu.org

Blue Swirl wrote:
> Hi,
> 
> These patches merge PCNet and Lance, implement the new IOMMU access 
> method and convert ESP and PCNet to use the new method.
> 
> At least Sparc works as before. I think the changes should not change PC 
> use of PCNet.

Still one remark: using bswap() is almost surely a bug (what if the host 
CPU is big endian ?). For correct code, you must use le16_to_cpu() or 
be16_to_cpu().

Regards,

Fabrice.