qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christophe Fillot <cf@utc.fr>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: esd audio output patch and debuging.
Date: Mon, 04 Sep 2006 14:01:08 +0200	[thread overview]
Message-ID: <44FC1584.2070407@utc.fr> (raw)
In-Reply-To: <200609041056.42244.kumbayo84@arcor.de>

Peter Oberndorfer a e'crit :
>
>
>      if (info->sign) {
> -        memset (buf, 0x00, len << info->shift);
> +        memset (buf, len << info->shift, 0x00);
>      }
>      else {
>          if (info->bits == 8) {
> -            memset (buf, 0x80, len << info->shift);
> +            memset (buf, len << info->shift, 0x80);
>          }
>
>
> This part looks wrong (swapped parameters)
>

Hello,

No, this is correct:

#include <string.h>

void *memset(void *s, int c, size_t n);

Best regards.

  reply	other threads:[~2006-09-04 12:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-03 22:33 [Qemu-devel] Re: esd audio output patch and debuging malc
2006-09-04  8:56 ` Peter Oberndorfer
2006-09-04 12:01   ` Christophe Fillot [this message]
2006-09-04 14:04     ` Peter Oberndorfer
2006-09-04 12:02   ` malc
  -- strict thread matches above, loose matches on Subject: below --
2006-09-04  0:07 malc
2006-09-04  5:33 ` Frederick Reeve
2006-08-30 15:45 [Qemu-devel] " Frederick Reeve
2006-08-31 11:46 ` [Qemu-devel] " malc
2006-08-31 17:19   ` Leonardo E. Reiter
2006-09-01 19:02     ` malc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44FC1584.2070407@utc.fr \
    --to=cf@utc.fr \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).