From: David Hildenbrand <david@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x <qemu-s390x@nongnu.org>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>,
Halil Pasic <pasic@linux.vnet.ibm.com>,
Janosch Frank <frankja@linux.vnet.ibm.com>,
"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
Michael Mueller <mimu@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] s390x/cpumodel: fix feature groups and breakage of MSA8
Date: Fri, 23 Mar 2018 08:42:04 +0100 [thread overview]
Message-ID: <44a34aee-6515-2682-0ef5-7fb874780d2a@redhat.com> (raw)
In-Reply-To: <c3d189be-29ae-9500-f1b1-c573c842a307@de.ibm.com>
On 20.03.2018 14:17, Christian Borntraeger wrote:
> David, Jason, Michael,
>
> the cpumodel code is somewhat fragile as we have to add maintain things
> in multiple places. I would like to have more robust code, e.g. by either
> generating more or by having build bug_ons or something like that.
> Any idea is highly welcome.
>
> Christian
Yes, error prone. I was also wondering if we should explicitly address
array items when initializing - e.g. in target/s390x/cpu_features.c the
"indexed by feature number for easy lookup" part. More LOC but less
error prone.
As Mimu also suggested, if we can generate something automatically, we
should do that.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-03-23 7:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 13:07 [Qemu-devel] [PATCH 1/1] s390x/cpumodel: fix feature groups and breakage of MSA8 Christian Borntraeger
2018-03-20 13:17 ` Christian Borntraeger
2018-03-20 15:06 ` Michael Mueller
2018-03-20 15:19 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2018-03-23 7:42 ` David Hildenbrand [this message]
2018-03-23 7:39 ` [Qemu-devel] " David Hildenbrand
2018-03-23 7:52 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44a34aee-6515-2682-0ef5-7fb874780d2a@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=mimu@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).