From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezHL1-0006Qw-Oj for qemu-devel@nongnu.org; Fri, 23 Mar 2018 03:42:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezHKy-0007Nb-N5 for qemu-devel@nongnu.org; Fri, 23 Mar 2018 03:42:11 -0400 References: <20180320130702.188689-1-borntraeger@de.ibm.com> From: David Hildenbrand Message-ID: <44a34aee-6515-2682-0ef5-7fb874780d2a@redhat.com> Date: Fri, 23 Mar 2018 08:42:04 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] s390x/cpumodel: fix feature groups and breakage of MSA8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , qemu-s390x Cc: qemu-devel , Cornelia Huck , Thomas Huth , Halil Pasic , Janosch Frank , "Jason J. Herne" , Michael Mueller On 20.03.2018 14:17, Christian Borntraeger wrote: > David, Jason, Michael, > > the cpumodel code is somewhat fragile as we have to add maintain things > in multiple places. I would like to have more robust code, e.g. by either > generating more or by having build bug_ons or something like that. > Any idea is highly welcome. > > Christian Yes, error prone. I was also wondering if we should explicitly address array items when initializing - e.g. in target/s390x/cpu_features.c the "indexed by feature number for easy lookup" part. More LOC but less error prone. As Mimu also suggested, if we can generate something automatically, we should do that. -- Thanks, David / dhildenb