From: Thomas Huth <thuth@redhat.com>
To: Nina Schoetterl-Glausch <nsg@linux.ibm.com>,
Shalini Chellathurai Saroja <shalini@linux.ibm.com>,
qemu-s390x mailing list <qemu-s390x@nongnu.org>
Cc: Daniel Berrange <berrange@redhat.com>,
qemu-devel mailing list <qemu-devel@nongnu.org>,
Hendrik Brueckner <brueckner@linux.ibm.com>
Subject: Re: [PATCH RFC] tests/functional: add tests for SCLP event CPI
Date: Thu, 11 Sep 2025 11:21:06 +0200 [thread overview]
Message-ID: <44a367bd-5242-4ddc-ad3e-b3dc718f549b@redhat.com> (raw)
In-Reply-To: <79a95a4349a8e97f65717139857432741701d489.camel@linux.ibm.com>
On 11/09/2025 11.05, Nina Schoetterl-Glausch wrote:
> On Tue, 2025-08-12 at 14:31 +0200, Shalini Chellathurai Saroja wrote:
>> Add tests for SCLP event type Control-Program Identification
>> (CPI) to s390x CCW virtio tests.
>>
>> Please note that these tests are skipped as the guest OS does not
>> trigger the SCLP event type CPI when the command
>> 'echo 1 > /sys/firmware/cpi/set' is executed in the guest. I
>> believe that the guest OS must to be updated to support the SCLP
>> event type CPI.
>>
>> Signed-off-by: Shalini Chellathurai Saroja <shalini@linux.ibm.com>
>> Suggested-by: Thomas Huth <thuth@redhat.com>
>> ---
>> tests/functional/test_s390x_ccw_virtio.py | 24 +++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/tests/functional/test_s390x_ccw_virtio.py b/tests/functional/test_s390x_ccw_virtio.py
>> index 453711aa0f..c14379cbaa 100755
>> --- a/tests/functional/test_s390x_ccw_virtio.py
>> +++ b/tests/functional/test_s390x_ccw_virtio.py
>
> Is this the best file to put it?
> It seems mostly to be about device testing.
It's meant as generic testing of the s390-virtio-ccw machine. Of course, the
CPI testing could also be done in a separate file, but that means that you
have to go through booting of the guest there again ... so I'd rather prefer
to keep it here, so we only have to boot the guest once.
Thomas
prev parent reply other threads:[~2025-09-11 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 12:31 [PATCH RFC] tests/functional: add tests for SCLP event CPI Shalini Chellathurai Saroja
2025-08-25 11:30 ` Thomas Huth
2025-10-13 13:37 ` Shalini Chellathurai Saroja
2025-09-11 9:05 ` Nina Schoetterl-Glausch
2025-09-11 9:21 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44a367bd-5242-4ddc-ad3e-b3dc718f549b@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=brueckner@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=shalini@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).