From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cv1K7-00086U-2l for qemu-devel@nongnu.org; Mon, 03 Apr 2017 08:43:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cv1K2-0007G5-75 for qemu-devel@nongnu.org; Mon, 03 Apr 2017 08:43:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40502) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cv1K1-0007Ff-Um for qemu-devel@nongnu.org; Mon, 03 Apr 2017 08:43:02 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F31D880464 for ; Mon, 3 Apr 2017 12:42:55 +0000 (UTC) References: <1490621195-2228-1-git-send-email-armbru@redhat.com> <1490621195-2228-10-git-send-email-armbru@redhat.com> <20170403113703.GS2768@redhat.com> From: Max Reitz Message-ID: <44b23727-f5d4-0d64-0694-85c6dd601431@redhat.com> Date: Mon, 3 Apr 2017 14:42:48 +0200 MIME-Version: 1.0 In-Reply-To: <20170403113703.GS2768@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CRAumLDN30DcbIBeV0AE5TohInraVuBRk" Subject: Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Markus Armbruster Cc: qemu-devel@nongnu.org, kwolf@redhat.com, jdurgin@redhat.com, jcody@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CRAumLDN30DcbIBeV0AE5TohInraVuBRk From: Max Reitz To: "Daniel P. Berrange" , Markus Armbruster Cc: qemu-devel@nongnu.org, kwolf@redhat.com, jdurgin@redhat.com, jcody@redhat.com Message-ID: <44b23727-f5d4-0d64-0694-85c6dd601431@redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret References: <1490621195-2228-1-git-send-email-armbru@redhat.com> <1490621195-2228-10-git-send-email-armbru@redhat.com> <20170403113703.GS2768@redhat.com> In-Reply-To: <20170403113703.GS2768@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03.04.2017 13:37, Daniel P. Berrange wrote: > On Mon, Mar 27, 2017 at 03:26:33PM +0200, Markus Armbruster wrote: >> This reverts a part of commit 8a47e8e. We're having second thoughts >> on the QAPI schema (and thus the external interface), and haven't >> reached consensus, yet. Issues include: >> >> * BlockdevOptionsRbd member @password-secret isn't actually a >> password, it's a key generated by Ceph. >> >> * We're not sure where member @password-secret belongs (see the >> previous commit). >> >> * How @password-secret interacts with settings from a configuration >> file specified with @conf is undocumented. I suspect it's untested,= >> too. >> >> Let's avoid painting ourselves into a corner now, and revert the >> feature for 2.9. >> >> Note that users can still configure an authentication key with a >> configuration file. They probably do that anyway if they use Ceph >> outside QEMU as well. >=20 > NB, this makes blockdev-add largely useless for RBD from libvirt's POV,= > since we rely on the password-secret facility working to support apps > like openstack which won't configure the global config file for RBD. >=20 > Not a regression though, since blockdev-add is new - just means we won'= t > be able to use the new feature yet :-( How does it make blockdev-add totally useless? The only thing you cannot do is set passwords for rbd. Can this not be added as a new feature in the future? Max --CRAumLDN30DcbIBeV0AE5TohInraVuBRk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFGBAEBCAAwFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAljiQ0gSHG1yZWl0ekBy ZWRoYXQuY29tAAoJEPQH2wBh1c9ArKwIAIhEEwn0RmNh+wv4fYH9erv+jgROTZPV cVBHczo5q3HbqwYd4BrVKRNOO+X0hauod3xJTmvWYX+Z1jZrmdY/ok9hjianUfN1 woexxWMcrDioosikZRf3ITgadLDcpiERUlHwFDcifHF9JtVh29pT/z9fFleJXAu7 WBelUX7B/xYZQnWqwXiSGto2cetAKsgWnwe6reJjnYwtrnvoMs3uQkX6V3r6FRQG sOLra3f1kJR7/f1PVxYlIenMcaNLe6BaDq3HYf9UfMNKUL6z6eV7woLiatt4U5PQ 11ZmpSB0bcIEwlvVkTvI6I/eeZqQLN1LzPfU3LTi0fcjloPIw1ClfpA= =IRES -----END PGP SIGNATURE----- --CRAumLDN30DcbIBeV0AE5TohInraVuBRk--