From: John Snow <jsnow@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/7] block: Add Error parameter to bdrv_amend_options
Date: Wed, 9 May 2018 18:57:16 -0400 [thread overview]
Message-ID: <44b781c3-0fdc-249a-ab2c-705538f155b8@redhat.com> (raw)
In-Reply-To: <20180509210023.20283-3-mreitz@redhat.com>
On 05/09/2018 05:00 PM, Max Reitz wrote:
> Looking at the qcow2 code that is riddled with error_report() calls,
> this is really how it should have been from the start.
>
> Along the way, turn the target_version/current_version comparisons at
> the beginning of qcow2_downgrade() into assertions (the caller has to
> make sure these conditions are met), and rephrase the error message on
> using compat=1.1 to get refcount widths other than 16 bits.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
thx@u
next prev parent reply other threads:[~2018-05-09 22:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 21:00 [Qemu-devel] [PATCH v2 0/7] qemu-img: Improve option help for amend Max Reitz
2018-05-09 21:00 ` [Qemu-devel] [PATCH v2 1/7] qemu-img: Amendment support implies create_opts Max Reitz
2018-05-09 21:00 ` [Qemu-devel] [PATCH v2 2/7] block: Add Error parameter to bdrv_amend_options Max Reitz
2018-05-09 21:20 ` Eric Blake
2018-05-09 22:57 ` John Snow [this message]
2018-05-09 21:00 ` [Qemu-devel] [PATCH v2 3/7] qemu-option: Pull out "Supported options" print Max Reitz
2018-05-09 21:00 ` [Qemu-devel] [PATCH v2 4/7] qemu-img: Add print_amend_option_help() Max Reitz
2018-05-09 21:00 ` [Qemu-devel] [PATCH v2 5/7] qemu-img: Recognize no creation support in -o help Max Reitz
2018-05-09 21:00 ` [Qemu-devel] [PATCH v2 6/7] iotests: Test help option for unsupporting formats Max Reitz
2018-05-09 21:00 ` [Qemu-devel] [PATCH v2 7/7] iotests: Rework 113 Max Reitz
2018-06-01 11:06 ` [Qemu-devel] [PATCH v2 0/7] qemu-img: Improve option help for amend Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44b781c3-0fdc-249a-ab2c-705538f155b8@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).