From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGY1U-0000d6-TG for qemu-devel@nongnu.org; Wed, 09 May 2018 18:57:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGY1U-0005CM-8t for qemu-devel@nongnu.org; Wed, 09 May 2018 18:57:25 -0400 References: <20180509210023.20283-1-mreitz@redhat.com> <20180509210023.20283-3-mreitz@redhat.com> From: John Snow Message-ID: <44b781c3-0fdc-249a-ab2c-705538f155b8@redhat.com> Date: Wed, 9 May 2018 18:57:16 -0400 MIME-Version: 1.0 In-Reply-To: <20180509210023.20283-3-mreitz@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/7] block: Add Error parameter to bdrv_amend_options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org On 05/09/2018 05:00 PM, Max Reitz wrote: > Looking at the qcow2 code that is riddled with error_report() calls, > this is really how it should have been from the start. > > Along the way, turn the target_version/current_version comparisons at > the beginning of qcow2_downgrade() into assertions (the caller has to > make sure these conditions are met), and rephrase the error message on > using compat=1.1 to get refcount widths other than 16 bits. > > Signed-off-by: Max Reitz Reviewed-by: John Snow thx@u