From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Michal Privoznik <mprivozn@redhat.com>
Subject: Re: [PATCH v3 3/6] migration: Factor out checks for advised and listening incomming postcopy
Date: Mon, 9 Jan 2023 15:39:36 +0100 [thread overview]
Message-ID: <44b9b396-f3ae-5066-4674-4c4eac5f9b2e@redhat.com> (raw)
In-Reply-To: <Y7cGdweVxbGlcvWh@x1n>
On 05.01.23 18:18, Peter Xu wrote:
> On Thu, Dec 22, 2022 at 12:02:12PM +0100, David Hildenbrand wrote:
>> +bool migration_incoming_postcopy_listening(void)
>> +{
>> + PostcopyState ps = postcopy_state_get();
>> +
>> + return ps >= POSTCOPY_INCOMING_LISTENING && ps < POSTCOPY_INCOMING_END;
>> +}
>
> This name is misleading, IMHO.
>
> The code means "we passed listening phase" but the name implies "we're
> listening". We can add the "incoming" into that if we want, though.
>
Let me call that migration_incoming_postcopy_running(). Thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2023-01-09 14:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 11:02 [PATCH v3 0/6] virtio-mem: Handle preallocation with migration David Hildenbrand
2022-12-22 11:02 ` [PATCH v3 1/6] migration: Allow immutable device state to be migrated early (i.e., before RAM) David Hildenbrand
2022-12-23 9:34 ` David Hildenbrand
2023-01-05 1:27 ` Michael S. Tsirkin
2023-01-05 8:20 ` David Hildenbrand
2023-01-04 17:23 ` Peter Xu
2023-01-05 8:35 ` David Hildenbrand
2023-01-05 17:15 ` Peter Xu
2023-01-09 14:34 ` David Hildenbrand
2023-01-09 19:54 ` Peter Xu
2023-01-10 10:18 ` David Hildenbrand
2023-01-10 11:52 ` David Hildenbrand
2023-01-10 20:03 ` Peter Xu
2023-01-11 13:48 ` David Hildenbrand
2023-01-11 16:35 ` Peter Xu
2023-01-11 16:58 ` David Hildenbrand
2023-01-11 17:28 ` Peter Xu
2023-01-11 17:44 ` David Hildenbrand
2022-12-22 11:02 ` [PATCH v3 2/6] migration/vmstate: Introduce VMSTATE_WITH_TMP_TEST() and VMSTATE_BITMAP_TEST() David Hildenbrand
2023-01-05 17:33 ` Dr. David Alan Gilbert
2022-12-22 11:02 ` [PATCH v3 3/6] migration: Factor out checks for advised and listening incomming postcopy David Hildenbrand
2023-01-05 17:18 ` Peter Xu
2023-01-09 14:39 ` David Hildenbrand [this message]
2023-01-09 14:42 ` David Hildenbrand
2022-12-22 11:02 ` [PATCH v3 4/6] virtio-mem: Fail if a memory backend with "prealloc=on" is specified David Hildenbrand
2022-12-22 11:02 ` [PATCH v3 5/6] virtio-mem: Migrate bitmap, size and sanity checks early David Hildenbrand
2022-12-22 11:02 ` [PATCH v3 6/6] virtio-mem: Proper support for preallocation with migration David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44b9b396-f3ae-5066-4674-4c4eac5f9b2e@redhat.com \
--to=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mprivozn@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).