From: Fabrice Bellard <fabrice@bellard.org>
To: ratchetr@sprynet.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] block-vvfat RW patch
Date: Sat, 09 Sep 2006 14:05:43 +0200 [thread overview]
Message-ID: <4502AE17.6060301@bellard.org> (raw)
In-Reply-To: <002a01c6d07d$e1c98e50$7d00a8c0@DELL3G>
Roger Lathrop wrote:
> 3) Changed sector2cluster to return a signed int, and added type casts
> to force the division to be signed.
This is not safe. vvfat_write must be modified to handle the case where
sectors are written before s->faked_sectors (maybe ignoring the write
could suffice).
Regards,
Fabrice.
prev parent reply other threads:[~2006-09-09 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 23:57 [Qemu-devel] block-vvfat RW patch Roger Lathrop
2006-09-05 9:36 ` Kazu
2006-09-09 12:05 ` Fabrice Bellard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4502AE17.6060301@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
--cc=ratchetr@sprynet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).