From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1GM1aU-00011o-Jq
	for qemu-devel@nongnu.org; Sat, 09 Sep 2006 08:05:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1GM1aR-00010n-Ru
	for qemu-devel@nongnu.org; Sat, 09 Sep 2006 08:05:30 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1GM1aR-00010j-Mc
	for qemu-devel@nongnu.org; Sat, 09 Sep 2006 08:05:27 -0400
Received: from [84.96.92.61] (helo=sMtp.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1GM1bG-0006ZC-26
	for qemu-devel@nongnu.org; Sat, 09 Sep 2006 08:06:18 -0400
Received: from [84.102.211.78] by sp604002mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0J5B00GPYQWPKZF0@sp604002mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Sat, 09 Sep 2006 14:05:13 +0200 (CEST)
Date: Sat, 09 Sep 2006 14:05:43 +0200
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] block-vvfat RW patch
In-reply-to: <002a01c6d07d$e1c98e50$7d00a8c0@DELL3G>
Message-id: <4502AE17.6060301@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii; format=flowed
Content-transfer-encoding: 7BIT
References: <002a01c6d07d$e1c98e50$7d00a8c0@DELL3G>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: ratchetr@sprynet.com
Cc: qemu-devel@nongnu.org

Roger Lathrop wrote:

> 3) Changed sector2cluster to return a signed int, and added type casts 
> to force the division to be signed.

This is not safe. vvfat_write must be modified to handle the case where 
sectors are written before s->faked_sectors (maybe ignoring the write 
could suffice).

Regards,

Fabrice.