From: Fabrice Bellard <fabrice@bellard.org>
To: samuel.thibault@ens-lyon.org
Cc: guillem@debian.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] PCI Bios fixup
Date: Sat, 09 Sep 2006 14:10:01 +0200 [thread overview]
Message-ID: <4502AF19.6050002@bellard.org> (raw)
In-Reply-To: <20060907010229.GF6876@bouh.residence.ens-lyon.fr>
Right, this is better. An even better fix would be to clear CS.RPL
before the popf.
Regards,
Fabrice.
Samuel Thibault wrote:
> Hi,
>
> The patch that qemu applies to bochs bios is a bit bugged:
>
> pci_pro_fail:
> pop edi
> pop esi
> - sti
> popf
> stc
> + and dword ptr[esp+4],0xfffffffc ;; reset CS.RPL for kqemu
> retf
>
> The and operation clears carry... So that pci functions always leave
> carry clear, and hence tell operating systems that they always work...
> This should rather be:
>
> pci_pro_fail:
> pop edi
> pop esi
> - sti
> popf
> + and dword ptr[esp+4],0xfffffffc ;; reset CS.RPL for kqemu
> stc
> retf
>
> Samuel
>
>
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
>
>
prev parent reply other threads:[~2006-09-09 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-07 1:02 [Qemu-devel] PCI Bios fixup Samuel Thibault
2006-09-09 12:10 ` Fabrice Bellard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4502AF19.6050002@bellard.org \
--to=fabrice@bellard.org \
--cc=guillem@debian.org \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).